Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tools] Throw FailError with code context on babel/parser exception #22810

Merged
merged 2 commits into from
Sep 13, 2018
Merged

[Tools] Throw FailError with code context on babel/parser exception #22810

merged 2 commits into from
Sep 13, 2018

Conversation

LeanidShutau
Copy link
Contributor

@babel/parser syntax errors should be described on throwing them to console.

@LeanidShutau LeanidShutau added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n v6.5.0 labels Sep 7, 2018
@LeanidShutau LeanidShutau self-assigned this Sep 7, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeanidShutau
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@LeanidShutau
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

pavel06081991
pavel06081991 approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

azasypkin
azasypkin approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on JS, html and pug file, worked as expected, just one nit.

src/dev/i18n/utils.js Outdated
@@ -84,3 +85,26 @@ export function* traverseNodes(nodes) {
}
}
}

/**
* @param {string} content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please add a detailed description here so that it is clear what this function does

@maryia-lapata maryia-lapata removed their request for review September 11, 2018 11:29
@elastic elastic deleted a comment from elasticmachine Sep 11, 2018
@elastic elastic deleted a comment from elasticmachine Sep 11, 2018
@pavel06081991
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata merged commit 974e234 into elastic:master Sep 13, 2018
@maryia-lapata maryia-lapata deleted the fix/i18n-unhandled-error-output branch September 13, 2018 10:11
@maryia-lapata maryia-lapata mentioned this pull request Sep 13, 2018
Merged
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Sep 13, 2018
@LeanidShutau @MaryiaLapata
[Tools] Throw FailError with code context on babel/parser exception (e…
16873b3 
…lastic#22810)

* [Tools] Throw FailError with code context on babel/parser exception

* Add description for createParserErrorMessage function
maryia-lapata added a commit that referenced this pull request Sep 13, 2018
@maryia-lapata
[Tools] Throw FailError with code context on babel/parser exception (#…
0a44c3f 
…22810) (#22992)

* [Tools] Throw FailError with code context on babel/parser exception

* Add description for createParserErrorMessage function
@LeanidShutau
Copy link
Contributor Author

6.x/6.5: 0a44c3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel06081991 pavel06081991 pavel06081991 approved these changes

@azasypkin azasypkin azasypkin approved these changes

Assignees

@LeanidShutau LeanidShutau

Labels
backported Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeanidShutau @elasticmachine @pavel06081991 @azasypkin @maryia-lapata