[skip ci] docs: dashboard import/export API #22835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
reviewed
Sep 7, 2018
| -------------------------------------------------- | ||
| // KIBANA | ||
|
|
||
| A successful call returns a response code of `200`. |
There was a problem hiding this comment.
This API returns 200 regardless if there are errors within the bulk operations or not. That indicates that the bulk operation itself was successful, but the user will still need to check the results for any errors that may occurred.
simianhacker
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
I just left a short note that we might want to add. I know in the past people were confused that by the fact that it returns 200 on import even when individual operations fail but it's designed this way to be consistent with how the bulk api's work in Elasticsearch.
|
I pushed some clarifying text for the error handling on import. |
epixa
added a commit
that referenced
this pull request
Sep 7, 2018
* docs: dashboard import/export API * docs: clarify response handling of errors in import api
epixa
added a commit
that referenced
this pull request
Sep 7, 2018
* docs: dashboard import/export API * docs: clarify response handling of errors in import api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14872