Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core/public] stop loadingCount, improve stop() tests #22937

Merged
merged 1 commit into from
Sep 11, 2018
Merged

[core/public] stop loadingCount, improve stop() tests #22937

merged 1 commit into from
Sep 11, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 11, 2018

Noticed that we forgot to stop the LoadingCountService in the CoreSystem and that the tests for CoreSystem.stop() were lacking, so fixed the bug and improved the tests.

@spalger spalger added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.5.0 labels Sep 11, 2018
@spalger spalger requested review from epixa and azasypkin and removed request for epixa September 11, 2018 17:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

epixa
epixa approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@epixa epixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 284e029 into elastic:master Sep 11, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 11, 2018
[core/public] stop loadingCount, improve stop() tests (elastic#22937)
2ec8232
@spalger spalger mentioned this pull request Sep 11, 2018
Merged
spalger pushed a commit that referenced this pull request Sep 12, 2018
[6.x] [core/public] stop loadingCount, improve stop() tests (#22937) (#…
3c9fcd5 
…22948)

Backports the following commits to 6.x:
 - [core/public] stop loadingCount, improve stop() tests  (#22937)
@spalger
Copy link
Contributor Author

spalger commented Sep 12, 2018

6.x/6.5: 3c9fcd5

@spalger spalger deleted the fix/core-service-stop-loadingCount branch September 12, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epixa epixa epixa approved these changes

@azasypkin azasypkin Awaiting requested review from azasypkin

Assignees
No one assigned
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @elasticmachine @epixa