Saved Object Namespaces #22968
Closed
Saved Object Namespaces #22968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobelb
added
non-issue
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
Merged
epixa
added
the
Team:Core
|
It looks like this PR has conflicts, I assume with the saved object migrations PR that just got merged. |
That is correct, I'll be taking a look at resolving the conflicts a little later today and will update this and the spaces PR accordingly. |
|
Closing this out, I'll be opening up another one shortly that does the same thing but works with migrations |
|
Replaced by #23378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the concept of Saved Object Namespaces, which Spaces will be taking advantage of. This solves two primary pain-points, it allows us to prefix the very beginning of the Elasticsearch document IDs to prevent collisions, and it also makes the user experience when the Spaces plugin is disabled or removed more user friendly.
When Spaces isn't enabled, Saved Objects will continue to behave as they do today and their IDs will simply be type:id. However, when Saved Objects are in a namespace, as specified by the Spaces plugin, the ID will become namespace:type:id, which will prevent collisions and allow users to import/export objects between Spaces. Additionally, when a Saved Object is in a namespace, there will be an additional root level property of namespace, which allows us to efficiently query for objects within a namespace.
These changes are made in a backwards compatible manner for SavedObjectsClient consumers, and the namespace is simply an optional parameter on the interface to the SavedObjectsClient.