Canvas function/argument/value autocomplete #23200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
WIP
|
There's something funny about the way this is handling quoted values.
If I provide a value without quotes, the suggest stays open, but if I quote the value, it goes away. It does come back if I close the quotes and then go back into the value and start changing it though. |
|
The functionality feels good, nothing is immediately jumping out at me in that regard. I was considering whether we want to highlight the first item as soon as the autocomplete box appears (Slack does this), but the difference here is that the return/enter key is used to start a new line in the expression builder whereas in Slack you tend to work on the current line and use Enter to submit. Point being, I think what we have is preferable for our use case and I'm only noting this here to capture the thought for posterity's sake. There are a couple of minor visual tweaks that could be made - the mockups used a slightly different background color to differentiate the two panels, some spacing and font styling tweaks here and there, and we could probably shorten the height of the entire box once you narrow down to a single function or argument - but those could be done in a follow-up and shouldn't block this PR from moving along, in my opinion. LGTM! |
|
Took this for another quick spin this morning and had some feedback.
I clicked on
It seems odd to me that we aren't showing anything on the right hand side and not necessarily intuitive that I need to click on the function to get a description of it. Should we automatically highlight the first one?
Is this a standard format for providing argument suggestions? I'm a bit further removed from code editors these days but I'm wondering if there is a better way to represent the argument details. @ryankeairns what do you think?
|
|
@alexfrancoeur see my comment just prior to yours regarding highlighting the first item - it feels like a nice thing but I think it could bring some issues with regards to our use of multi-line expressions. We could try it out, but I suspect it could lead to a path where you end up needing to use Shift+Enter to start a new line. For our scenario, that seems like it would become cumbersome if you're wanting a new line and its suggesting the next thing (i.e. interpreting the Enter might get tricky). As an alternative (image below), we could display some higher level/more generic info on the right side when nothing is highlighted on the left side. Something to consider there is that the info would display over and over and would likely become not useful, quickly. Another option would be to not have it as wide, initially, and then expand once an item is highlighted.
As for the argument display, some of them can have long descriptions, so we (Rashid, Lukas, and I) discussed displaying them as fullwidth/single column as Lukas has done here (and as you see in TimeLion). I also had a note about this in my previous comment that I'd like to touch this up visually. Suffice it all to say, I think we should get this PR merged (once ready from a UX/technical standpoint) and I'll follow up with a PR for some UI enhancements. |
Yeah, public functions aren't being suggested now, it's a bug related to other stuff. I believe @rashidkpc is looking into that.
I'm not seeing this... Do you have steps to reproduce this consistently? |
|
FYI - I'm about to make some design tweaks and will push them up here when ready. |
|
@lukasolson I added some small design changes and opened a PR against your forked repo/branch 👉 lukasolson#16 |
Design tweaks for autocomplete
…eat/canvas/autocomplete
lukasolson
changed the title
|
Still working through writing tests but I think I've cleaned up the code enough that you can take a look. |
|
We're being pretty stingy with the vertical space. The PR I put up just worked to minimize that, so let's keep it as-is for the time being. Looking at that screenshot, I'm not sure my prior changes were in the branch tested... I added some space between those values to make them easier to read. |
💚 Build Succeeded |
|
Took it for a spin again, LGTM. Haven't run into any big issues. I'll leave the same feedback I did in slack. It might be nice to add a turn off autocomplete option that is user specific and stored locally. In case there is an issue, any user can turn this off and (hopefully) open an issue in the Kibana repo. |
|
@alexfrancoeur @lukasolson we have some free whitespace down in the lower left hand corner of the expression editor panel where we could place an EuiSwtich to toggle on/off the autocomplete feature:
Regardless of how it persists (per workpad/across workpads; presuming the latter), keeping it close and in context to the expression editor input itself feels like the best approach, imo. Side note: this is using the compressed prop which is the shorter version of this component. |
|
I like it! I think we discussed adding as a separate PR so we can get this
in
…On Thu, Oct 18, 2018, 9:56 AM Ryan Keairns ***@***.***> wrote:
@alexfrancoeur <https://github.com/alexfrancoeur> @lukasolson
<https://github.com/lukasolson> we have some free whitespace down in the
lower left hand corner of the expression editor panel where we could place
an EuiSwtich to toggle on/off the autocomplete feature:
[image: screenshot 2018-10-18 08 52 00]
<https://user-images.githubusercontent.com/446285/47159364-52818900-d2b3-11e8-8f5b-a0550d861292.png>
Regardless of how it persists (per workpad/across workpads; presuming the
latter), keeping it close and in context to the expression editor input
itself feels like the best approach, imo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23200 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYA-fz30WDSt3bxIkrAmtk6VNGfISPO9ks5umIiXgaJpZM4WptoV>
.
|
💔 Build Failed |
💚 Build Succeeded |
skh
added a commit
to skh/kibana
that referenced
this pull request
Oct 22, 2018
commit 7739410 Author: markharwood <markharwood@gmail.com> Date: Mon Oct 22 09:30:16 2018 +0100 Graph fix: Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610) Closes elastic#22054 commit 3ca2231 Author: markharwood <markharwood@gmail.com> Date: Mon Oct 22 09:27:17 2018 +0100 Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610) Closes elastic#22054 commit 98f7667 Author: Andrew Wilkins <axwalk@gmail.com> Date: Mon Oct 22 08:54:46 2018 +0800 [APM] Update Go agent instructions (elastic#24111) - Update the Go agent instructions to refer to the new import path. - Change some of the wording to align with other agents. - Drop "beta" warning. commit f6ba696 Author: Maryia Lapata <mary.lopato@gmail.com> Date: Sun Oct 21 15:39:15 2018 +0300 Fix broken link on Watcher (elastic#24317) commit 3fc8b35 Author: Josh Dover <me@joshdover.com> Date: Sat Oct 20 10:45:14 2018 -0500 Add server OS information to telemetry stats (elastic#23793) * Add server OS data to monitoring collector and telemetry * Fixup naming * Fix functional tests commit 9904bd9 Author: Spencer <email@spalger.com> Date: Fri Oct 19 20:29:38 2018 -0700 [uiSettings] upgrade old config on read (elastic#24108) * doing config migration during config get if necessary * fixing issue with writing new config when user does not have write privilege * [uiSettings] only log about config upgrade on success * [uiSettings/createOrUpgradeSavedConfig] add onWriteError option * [uiSettings] return the upgradeAttributes if reader is unable to write upgrade * [uiSettings] update route tests to cover upgrade on get * [spaces/integration-tests] add config doc to expected objects * [uiSettings] avoid shadowed variable name commit ab29946 Author: dave.snider@gmail.com <dave.snider@gmail.com> Date: Fri Oct 19 18:30:06 2018 -0700 update eui to 4.5.1 (elastic#24218) * update eui to 4.5.1 * icons declared for logging / infra * remove eui types that are now in EUI directly * clean up duplicated EUI typescript definitions * Fix EuiSelect usage in beats enrollment commit 6b4b0fe Author: Tyler Smalley <tylersmalley@me.com> Date: Fri Oct 19 17:15:29 2018 -0700 Updates build file unit tests to be Windows Compatible (elastic#24296) POSTIX permissions are not available on windows and libuv reports only 666 and 444 for if it's read or writeable. Additionally, on Windows and being reported on OSX, modifying directory timestamps in the same stream often does not work. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> commit 8ee620d Author: Tim Sullivan <tsullivan@users.noreply.github.com> Date: Fri Oct 19 15:44:23 2018 -0700 Add note about automatic inclusion of all stats (elastic#24309) commit 208bd51 Author: Spencer <email@spalger.com> Date: Fri Oct 19 15:28:12 2018 -0700 [core/public/chrome] migrate controls, theme, and visibility apis (elastic#22987) * [core/public/chrome] migrate controls, theme, and visibility apis * [core/public] stop uiSettings service * [core/public/chrome] test that observables stop immedaiately after stop() * fix typos * [core/public/legacyPlatform] test globalNavState init * [ui/chrome] don't pass extra params * [core/public/chrome] test for dedupe-handling * [ui/chrome/theme] test with different values for logo and smallLogo commit 2fa5ee5 Author: Josh Dover <me@joshdover.com> Date: Fri Oct 19 17:22:54 2018 -0500 Add euiIconType for InfraOps and Logs links (elastic#24289) commit 938d130 Author: Tyler Smalley <tylersmalley@me.com> Date: Fri Oct 19 15:10:27 2018 -0700 Updates file unit tests to be Windows compatible (elastic#24281) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> commit bd3f840 Author: Tim Sullivan <tsullivan@users.noreply.github.com> Date: Fri Oct 19 15:00:38 2018 -0700 [docs/reporting] note about data table pdf (elastic#23921) commit 9189c06 Author: Chris Cowan <chris@chriscowan.us> Date: Fri Oct 19 13:54:58 2018 -0700 [Infra UI] Test for waffle map GraphQL endpoint (elastic#24184) * [Infra UI] Test for metrics GraphQL endpoint * Moving apollo-boost to devDeps * Converting tests to typescript * Renaming infraops to infra * Converting to typescript * renaming from infraops to infra * Adding waffle tests back in commit 73d8bb9 Author: Peter Pisljar <peter.pisljar@gmail.com> Date: Fri Oct 19 20:40:05 2018 +0200 always start with closed context menu (elastic#24252) commit d8d2a18 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 21:02:58 2018 +0300 Translations for Management -> Objects (elastic#23905) * fix tests and update snapshots * fix id names * fix test and update snapshots * Update unit test snapshots * fix issues * Update snapshots * Fix issues commit 371eca2 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:56:50 2018 +0300 Translations for Advanced Settings (elastic#23881) * translate kbn.management.advanced_settings * fix tests and update snapshots * fix tests * fix issues * fix id in get_category-name.js * Update unit test snapshot * update snapshot * Fix issues commit a5c28d5 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:49:37 2018 +0300 Feature/translate watcher(part_3) (elastic#24066) * translate watcher(part_3) * fix default message in monitoring_watch.js * fix issues * fix issues * fix issues * fix issues commit fa95143 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:48:31 2018 +0300 Feature/translate watcher(part_2) (elastic#24017) * translate watcher(pad_2) * fix issues * fix issues commit 6247189 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:47:05 2018 +0300 Feature/translate watcher(part_1) (elastic#23989) * translate watcher(pad_1) * fix test * fix issues * fix the same id name * fix default message * fix issues commit 3c15067 Author: Chris Cowan <chris@chriscowan.us> Date: Fri Oct 19 10:39:21 2018 -0700 [Infra UI] Test for metrics GraphQL endpoint (elastic#24179) * [Infra UI] Test for metrics GraphQL endpoint * Moving apollo-boost to devDeps * Converting tests to typescript * Renaming infraops to infra commit c5e61c3 Author: Stacey Gammon <gammon@elastic.co> Date: Fri Oct 19 13:21:12 2018 -0400 EAH - Typescript state_monitor_factory (elastic#23945) * Typescript state_monitor_factory * Fix linter error with possibly undefined * Expand typings to include hash stuff and expand the State type definition more. * Mark readonly commit cc75547 Author: tibmt <pavelyukhnevich@yandex.ru> Date: Fri Oct 19 18:25:55 2018 +0300 Translate Gauge and Goal (elastic#23882) * Translate Gauge and Goal * fix some names, rewrite some code and add 'kbnVislibVisTypes' to '.i18nrc.json' * add 'Required' translation * fix 'requiredText' bug * use \' instead of " * update heatmap component * Update gauge.js * Update gauge.js * Update gauge.js commit 4b9e13c Author: Maryia Lapata <mary.lopato@gmail.com> Date: Fri Oct 19 17:59:07 2018 +0300 Init I18n before Notifications start (elastic#23902) * Init I18n before Notifications start * Remove i18n initialization in AngularJS since it will be already initialized in CoreSystem * Remove unused translationsApi * Remove redundant i18n.init invocation * Remove i18n tests since i18n.init was removed and input params for AppBootstrap were changed * Move i18n initialization to the entry file. commit 03d14a7 Author: Bill McConaghy <bill.mcconaghy@elastic.co> Date: Fri Oct 19 10:48:41 2018 -0400 fixing mangling of floating point numbers by console (elastic#23685) * fixing mangling of floating point numbers by console * fixing tests * fixing issue with large requests * restoring old code for server side as it handles large responses better commit a23124e Author: Matt Apperson <me@mattapperson.com> Date: Fri Oct 19 10:17:45 2018 -0400 [BeatsCM] Fixes and issue where if security is disabled, BeatsCM breaks Kibana (elastic#24249) * fix spelling * fix license and security checks * removed unused vars * cleanup * remove security check from route def as it is already managed in-route commit da26fcb Author: Melissa Alvarez <melissa.alvarez@elastic.co> Date: Fri Oct 19 09:42:21 2018 +0100 [ML] Ensure applying/removing groups menu is keyboard accessible (elastic#24212) * add group list arrow nav * up/down moved into own functions * always prevent default on arrow key press commit db905c0 Author: dave.snider@gmail.com <dave.snider@gmail.com> Date: Thu Oct 18 18:12:39 2018 -0700 remove eui css import from beats/infra (elastic#24245) commit 314d1c4 Author: Lukas Olson <olson.lukas@gmail.com> Date: Thu Oct 18 13:37:44 2018 -0700 Canvas function/argument/value autocomplete (elastic#23200) * feat: canvas autocomplete * fix: remove unused files * autocomplete ui cleanup * fix: handle stuff inside quotes * fix: canvas suggestion comparator * fix: spaces at the beginning of expressions * fix: move header out of autocomplete component itself * fix: add tests * fix: failing test * fix: pointed to wrong module commit db77feb Author: Stacey Gammon <gammon@elastic.co> Date: Thu Oct 18 14:20:09 2018 -0400 Extend the timeout used to check if something exists. (elastic#24140) commit a2172b9 Author: Maryia Lapata <mary.lopato@gmail.com> Date: Thu Oct 18 20:41:23 2018 +0300 Fix structure of plural message (elastic#24208) commit 4cc0103 Author: Catherine Liu <catherineqliu@outlook.com> Date: Thu Oct 18 13:03:57 2018 -0400 Adds Canvas to Kibana Home (elastic#24038) * Adds Canvas to the feature registry * Removes timelion from the home page commit 2b6cd21 Author: Justin Kambic <justin.kambic@elastic.co> Date: Thu Oct 18 12:43:52 2018 -0400 [Logstash] [Pipeline Viewer] Improve LS monitoring accessibility (elastic#24169) * Update test data shape to conform to component proptypes. * Add aria-labels for pipeline viewer buttons. commit 9f4ec18 Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Thu Oct 18 09:30:42 2018 -0700 Reporting cookies (elastic#24177) * Switching Reporting to use session cookies explicitly * Fixing bug when security is explicitly disabled * Responding to feedback * Fixing yarn.lock commit 49168a9 Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Thu Oct 18 09:28:18 2018 -0700 Using ES list privileges API to determine the authorization mode (elastic#24211) * Making it easier and more terse to specify the user for a test * Using ES list privileges API to determine the authorization mode This let's us correct use RBAC authorization for the proper users when security is enabled, and spaces is disabled to detect whether they have privileges of any kind and if so use RBAC. * Fixing authorization service test * Fixing tests referencing wrong expects * Putting create test back * Update x-pack/plugins/security/server/lib/authorization/mode.js * Update x-pack/plugins/security/server/lib/authorization/mode.js commit 612bd74 Author: Matt Apperson <me@mattapperson.com> Date: Thu Oct 18 12:16:31 2018 -0400 [BeatsCM] check for security after license, add support for standard license (elastic#24210) commit 46d1a81 Author: Matt Apperson <me@mattapperson.com> Date: Thu Oct 18 12:16:01 2018 -0400 merge RPM and DEB as they are the same command (elastic#24209) commit 7d0eaed Author: Gil Raphaelli <g@raphaelli.com> Date: Thu Oct 18 11:47:51 2018 -0400 update apm-server start instructions for deb/rpm/windows (elastic#24104) * update apm-server start instructions for deb/rpm * update apm-server start instructions for windows commit 2be837e Author: Jake Landis <jake.landis@elastic.co> Date: Thu Oct 18 10:28:42 2018 -0500 console: ingest node updates for auto-complete (elastic#24100) * add bytes processor * add dissect processor * add pipeline processor * add drop processor * add if conditional to each processor * add on_failure to each processor commit 5441d74 Author: Felix Stürmer <weltenwort@users.noreply.github.com> Date: Thu Oct 18 17:00:08 2018 +0200 Move mustache typings to devDependencies (elastic#24165) This moves the `@types/mustache` package from `dependencies` to `devDependencies` to avoid unnecessary inclusion in the build artifacts. commit b4cbac6 Author: Tim Roes <mail@timroes.de> Date: Thu Oct 18 15:49:48 2018 +0200 Fix memory leak in vislib on auto refresh (elastic#24134) commit f382ee2 Author: Chris Roberson <chrisronline@gmail.com> Date: Thu Oct 18 09:05:27 2018 -0400 Fixes from the demo (elastic#23922) commit 8fc52b4 Author: Pete Harverson <peteharverson@users.noreply.github.com> Date: Thu Oct 18 13:34:44 2018 +0100 [ML] Focus View Results link on Job wizards when job finishes (elastic#24190) * [ML] Focus View Results link on Job wizards when job finishes * [ML] Move function to set View Results link focus to new_job_utils commit 9a3414c Author: tibmt <pavelyukhnevich@yandex.ru> Date: Thu Oct 18 14:17:06 2018 +0300 Translate heatmap and heatmap_options (elastic#23812) Translation of Heatmap visualization component commit 58ba301 Author: tibmt <pavelyukhnevich@yandex.ru> Date: Thu Oct 18 13:58:57 2018 +0300 Translate Area, Line, Horizontal and Vertical Bar (elastic#23823) Translation of Line, Area, Vertical and Horizontal Bar visualization components commit c5d9583 Author: Pete Harverson <peteharverson@users.noreply.github.com> Date: Thu Oct 18 11:14:14 2018 +0100 [ML] Lowers multi-bucket impact thresholds used for anomaly display (elastic#24136) * [ML] Lowers multi-bucket impact thresholds used for anomaly display * [ML] Adjust thresholds used in multi bucket impact unit tests
skh
added a commit
to skh/kibana
that referenced
this pull request
Oct 22, 2018
Squashed commit of the following: commit 7739410 Author: markharwood <markharwood@gmail.com> Date: Mon Oct 22 09:30:16 2018 +0100 Graph fix: Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610) Closes elastic#22054 commit 3ca2231 Author: markharwood <markharwood@gmail.com> Date: Mon Oct 22 09:27:17 2018 +0100 Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610) Closes elastic#22054 commit 98f7667 Author: Andrew Wilkins <axwalk@gmail.com> Date: Mon Oct 22 08:54:46 2018 +0800 [APM] Update Go agent instructions (elastic#24111) - Update the Go agent instructions to refer to the new import path. - Change some of the wording to align with other agents. - Drop "beta" warning. commit f6ba696 Author: Maryia Lapata <mary.lopato@gmail.com> Date: Sun Oct 21 15:39:15 2018 +0300 Fix broken link on Watcher (elastic#24317) commit 3fc8b35 Author: Josh Dover <me@joshdover.com> Date: Sat Oct 20 10:45:14 2018 -0500 Add server OS information to telemetry stats (elastic#23793) * Add server OS data to monitoring collector and telemetry * Fixup naming * Fix functional tests commit 9904bd9 Author: Spencer <email@spalger.com> Date: Fri Oct 19 20:29:38 2018 -0700 [uiSettings] upgrade old config on read (elastic#24108) * doing config migration during config get if necessary * fixing issue with writing new config when user does not have write privilege * [uiSettings] only log about config upgrade on success * [uiSettings/createOrUpgradeSavedConfig] add onWriteError option * [uiSettings] return the upgradeAttributes if reader is unable to write upgrade * [uiSettings] update route tests to cover upgrade on get * [spaces/integration-tests] add config doc to expected objects * [uiSettings] avoid shadowed variable name commit ab29946 Author: dave.snider@gmail.com <dave.snider@gmail.com> Date: Fri Oct 19 18:30:06 2018 -0700 update eui to 4.5.1 (elastic#24218) * update eui to 4.5.1 * icons declared for logging / infra * remove eui types that are now in EUI directly * clean up duplicated EUI typescript definitions * Fix EuiSelect usage in beats enrollment commit 6b4b0fe Author: Tyler Smalley <tylersmalley@me.com> Date: Fri Oct 19 17:15:29 2018 -0700 Updates build file unit tests to be Windows Compatible (elastic#24296) POSTIX permissions are not available on windows and libuv reports only 666 and 444 for if it's read or writeable. Additionally, on Windows and being reported on OSX, modifying directory timestamps in the same stream often does not work. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> commit 8ee620d Author: Tim Sullivan <tsullivan@users.noreply.github.com> Date: Fri Oct 19 15:44:23 2018 -0700 Add note about automatic inclusion of all stats (elastic#24309) commit 208bd51 Author: Spencer <email@spalger.com> Date: Fri Oct 19 15:28:12 2018 -0700 [core/public/chrome] migrate controls, theme, and visibility apis (elastic#22987) * [core/public/chrome] migrate controls, theme, and visibility apis * [core/public] stop uiSettings service * [core/public/chrome] test that observables stop immedaiately after stop() * fix typos * [core/public/legacyPlatform] test globalNavState init * [ui/chrome] don't pass extra params * [core/public/chrome] test for dedupe-handling * [ui/chrome/theme] test with different values for logo and smallLogo commit 2fa5ee5 Author: Josh Dover <me@joshdover.com> Date: Fri Oct 19 17:22:54 2018 -0500 Add euiIconType for InfraOps and Logs links (elastic#24289) commit 938d130 Author: Tyler Smalley <tylersmalley@me.com> Date: Fri Oct 19 15:10:27 2018 -0700 Updates file unit tests to be Windows compatible (elastic#24281) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> commit bd3f840 Author: Tim Sullivan <tsullivan@users.noreply.github.com> Date: Fri Oct 19 15:00:38 2018 -0700 [docs/reporting] note about data table pdf (elastic#23921) commit 9189c06 Author: Chris Cowan <chris@chriscowan.us> Date: Fri Oct 19 13:54:58 2018 -0700 [Infra UI] Test for waffle map GraphQL endpoint (elastic#24184) * [Infra UI] Test for metrics GraphQL endpoint * Moving apollo-boost to devDeps * Converting tests to typescript * Renaming infraops to infra * Converting to typescript * renaming from infraops to infra * Adding waffle tests back in commit 73d8bb9 Author: Peter Pisljar <peter.pisljar@gmail.com> Date: Fri Oct 19 20:40:05 2018 +0200 always start with closed context menu (elastic#24252) commit d8d2a18 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 21:02:58 2018 +0300 Translations for Management -> Objects (elastic#23905) * fix tests and update snapshots * fix id names * fix test and update snapshots * Update unit test snapshots * fix issues * Update snapshots * Fix issues commit 371eca2 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:56:50 2018 +0300 Translations for Advanced Settings (elastic#23881) * translate kbn.management.advanced_settings * fix tests and update snapshots * fix tests * fix issues * fix id in get_category-name.js * Update unit test snapshot * update snapshot * Fix issues commit a5c28d5 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:49:37 2018 +0300 Feature/translate watcher(part_3) (elastic#24066) * translate watcher(part_3) * fix default message in monitoring_watch.js * fix issues * fix issues * fix issues * fix issues commit fa95143 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:48:31 2018 +0300 Feature/translate watcher(part_2) (elastic#24017) * translate watcher(pad_2) * fix issues * fix issues commit 6247189 Author: Nox911 <nox.911@gmail.com> Date: Fri Oct 19 20:47:05 2018 +0300 Feature/translate watcher(part_1) (elastic#23989) * translate watcher(pad_1) * fix test * fix issues * fix the same id name * fix default message * fix issues commit 3c15067 Author: Chris Cowan <chris@chriscowan.us> Date: Fri Oct 19 10:39:21 2018 -0700 [Infra UI] Test for metrics GraphQL endpoint (elastic#24179) * [Infra UI] Test for metrics GraphQL endpoint * Moving apollo-boost to devDeps * Converting tests to typescript * Renaming infraops to infra commit c5e61c3 Author: Stacey Gammon <gammon@elastic.co> Date: Fri Oct 19 13:21:12 2018 -0400 EAH - Typescript state_monitor_factory (elastic#23945) * Typescript state_monitor_factory * Fix linter error with possibly undefined * Expand typings to include hash stuff and expand the State type definition more. * Mark readonly commit cc75547 Author: tibmt <pavelyukhnevich@yandex.ru> Date: Fri Oct 19 18:25:55 2018 +0300 Translate Gauge and Goal (elastic#23882) * Translate Gauge and Goal * fix some names, rewrite some code and add 'kbnVislibVisTypes' to '.i18nrc.json' * add 'Required' translation * fix 'requiredText' bug * use \' instead of " * update heatmap component * Update gauge.js * Update gauge.js * Update gauge.js commit 4b9e13c Author: Maryia Lapata <mary.lopato@gmail.com> Date: Fri Oct 19 17:59:07 2018 +0300 Init I18n before Notifications start (elastic#23902) * Init I18n before Notifications start * Remove i18n initialization in AngularJS since it will be already initialized in CoreSystem * Remove unused translationsApi * Remove redundant i18n.init invocation * Remove i18n tests since i18n.init was removed and input params for AppBootstrap were changed * Move i18n initialization to the entry file. commit 03d14a7 Author: Bill McConaghy <bill.mcconaghy@elastic.co> Date: Fri Oct 19 10:48:41 2018 -0400 fixing mangling of floating point numbers by console (elastic#23685) * fixing mangling of floating point numbers by console * fixing tests * fixing issue with large requests * restoring old code for server side as it handles large responses better commit a23124e Author: Matt Apperson <me@mattapperson.com> Date: Fri Oct 19 10:17:45 2018 -0400 [BeatsCM] Fixes and issue where if security is disabled, BeatsCM breaks Kibana (elastic#24249) * fix spelling * fix license and security checks * removed unused vars * cleanup * remove security check from route def as it is already managed in-route commit da26fcb Author: Melissa Alvarez <melissa.alvarez@elastic.co> Date: Fri Oct 19 09:42:21 2018 +0100 [ML] Ensure applying/removing groups menu is keyboard accessible (elastic#24212) * add group list arrow nav * up/down moved into own functions * always prevent default on arrow key press commit db905c0 Author: dave.snider@gmail.com <dave.snider@gmail.com> Date: Thu Oct 18 18:12:39 2018 -0700 remove eui css import from beats/infra (elastic#24245) commit 314d1c4 Author: Lukas Olson <olson.lukas@gmail.com> Date: Thu Oct 18 13:37:44 2018 -0700 Canvas function/argument/value autocomplete (elastic#23200) * feat: canvas autocomplete * fix: remove unused files * autocomplete ui cleanup * fix: handle stuff inside quotes * fix: canvas suggestion comparator * fix: spaces at the beginning of expressions * fix: move header out of autocomplete component itself * fix: add tests * fix: failing test * fix: pointed to wrong module commit db77feb Author: Stacey Gammon <gammon@elastic.co> Date: Thu Oct 18 14:20:09 2018 -0400 Extend the timeout used to check if something exists. (elastic#24140) commit a2172b9 Author: Maryia Lapata <mary.lopato@gmail.com> Date: Thu Oct 18 20:41:23 2018 +0300 Fix structure of plural message (elastic#24208) commit 4cc0103 Author: Catherine Liu <catherineqliu@outlook.com> Date: Thu Oct 18 13:03:57 2018 -0400 Adds Canvas to Kibana Home (elastic#24038) * Adds Canvas to the feature registry * Removes timelion from the home page commit 2b6cd21 Author: Justin Kambic <justin.kambic@elastic.co> Date: Thu Oct 18 12:43:52 2018 -0400 [Logstash] [Pipeline Viewer] Improve LS monitoring accessibility (elastic#24169) * Update test data shape to conform to component proptypes. * Add aria-labels for pipeline viewer buttons. commit 9f4ec18 Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Thu Oct 18 09:30:42 2018 -0700 Reporting cookies (elastic#24177) * Switching Reporting to use session cookies explicitly * Fixing bug when security is explicitly disabled * Responding to feedback * Fixing yarn.lock commit 49168a9 Author: Brandon Kobel <brandon.kobel@gmail.com> Date: Thu Oct 18 09:28:18 2018 -0700 Using ES list privileges API to determine the authorization mode (elastic#24211) * Making it easier and more terse to specify the user for a test * Using ES list privileges API to determine the authorization mode This let's us correct use RBAC authorization for the proper users when security is enabled, and spaces is disabled to detect whether they have privileges of any kind and if so use RBAC. * Fixing authorization service test * Fixing tests referencing wrong expects * Putting create test back * Update x-pack/plugins/security/server/lib/authorization/mode.js * Update x-pack/plugins/security/server/lib/authorization/mode.js commit 612bd74 Author: Matt Apperson <me@mattapperson.com> Date: Thu Oct 18 12:16:31 2018 -0400 [BeatsCM] check for security after license, add support for standard license (elastic#24210) commit 46d1a81 Author: Matt Apperson <me@mattapperson.com> Date: Thu Oct 18 12:16:01 2018 -0400 merge RPM and DEB as they are the same command (elastic#24209) commit 7d0eaed Author: Gil Raphaelli <g@raphaelli.com> Date: Thu Oct 18 11:47:51 2018 -0400 update apm-server start instructions for deb/rpm/windows (elastic#24104) * update apm-server start instructions for deb/rpm * update apm-server start instructions for windows commit 2be837e Author: Jake Landis <jake.landis@elastic.co> Date: Thu Oct 18 10:28:42 2018 -0500 console: ingest node updates for auto-complete (elastic#24100) * add bytes processor * add dissect processor * add pipeline processor * add drop processor * add if conditional to each processor * add on_failure to each processor commit 5441d74 Author: Felix Stürmer <weltenwort@users.noreply.github.com> Date: Thu Oct 18 17:00:08 2018 +0200 Move mustache typings to devDependencies (elastic#24165) This moves the `@types/mustache` package from `dependencies` to `devDependencies` to avoid unnecessary inclusion in the build artifacts. commit b4cbac6 Author: Tim Roes <mail@timroes.de> Date: Thu Oct 18 15:49:48 2018 +0200 Fix memory leak in vislib on auto refresh (elastic#24134) commit f382ee2 Author: Chris Roberson <chrisronline@gmail.com> Date: Thu Oct 18 09:05:27 2018 -0400 Fixes from the demo (elastic#23922) commit 8fc52b4 Author: Pete Harverson <peteharverson@users.noreply.github.com> Date: Thu Oct 18 13:34:44 2018 +0100 [ML] Focus View Results link on Job wizards when job finishes (elastic#24190) * [ML] Focus View Results link on Job wizards when job finishes * [ML] Move function to set View Results link focus to new_job_utils commit 9a3414c Author: tibmt <pavelyukhnevich@yandex.ru> Date: Thu Oct 18 14:17:06 2018 +0300 Translate heatmap and heatmap_options (elastic#23812) Translation of Heatmap visualization component commit 58ba301 Author: tibmt <pavelyukhnevich@yandex.ru> Date: Thu Oct 18 13:58:57 2018 +0300 Translate Area, Line, Horizontal and Vertical Bar (elastic#23823) Translation of Line, Area, Vertical and Horizontal Bar visualization components commit c5d9583 Author: Pete Harverson <peteharverson@users.noreply.github.com> Date: Thu Oct 18 11:14:14 2018 +0100 [ML] Lowers multi-bucket impact thresholds used for anomaly display (elastic#24136) * [ML] Lowers multi-bucket impact thresholds used for anomaly display * [ML] Adjust thresholds used in multi bucket impact unit tests
lukasolson
added a commit
that referenced
this pull request
Oct 22, 2018
* feat: canvas autocomplete * fix: remove unused files * autocomplete ui cleanup * fix: handle stuff inside quotes * fix: canvas suggestion comparator * fix: spaces at the beginning of expressions * fix: move header out of autocomplete component itself * fix: add tests * fix: failing test * fix: pointed to wrong module
|
6.x (6.5.0): 7ff4f81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Canvas expression input with autocomplete capabilities, so that functions, arguments, and in some cases even values can be suggested. When they are suggested and highlighted, we show the corresponding reference when available.
Note that this PR updates the
argdefinition to have anoptionsarray, which are what will be suggested for values. In the future we'd like to make this more robust and provide a more flexible way to generate suggestions, but this works for now.