[Infra UI] Add Node Type Selector to Waffle Map #23593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
force-pushed
the
waffle-node-type-selector
branch
from
52ba5d7 to
33ea6ef
Compare
💔 Build Failed |
|
Works as described 👍 The waffle map doesn't show the |
|
@skh Looks like there was a typo in a previous PR. We just didn't test it because we couldn't change to a pods view. |
💔 Build Failed |
|
jenkins test this |
|
I just added fixes for #21764 for APM link |
💔 Build Failed |
This was referenced Sep 28, 2018
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the node type selector to the waffle map page. There are also fixes for the drill down links.