Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Add URL State to Waffle Map #23649

Merged
merged 2 commits into from
Oct 2, 2018
Merged

[Infra UI] Add URL State to Waffle Map #23649

merged 2 commits into from
Oct 2, 2018

Conversation

simianhacker
Copy link
Member

This PR fixes the name WithWaffleOptionsUrlState and adds it to the home page so the URL will serialize the state.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@simianhacker
Copy link
Member Author

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@simianhacker simianhacker requested a review from XavierM October 1, 2018 18:51
weltenwort
weltenwort requested changes Oct 1, 2018
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost works 😉

We only need to use the bound action creators changeGroupBy and changeNodeType from the function argument (as for changeMetrics) in

kibana/x-pack/plugins/infra/public/containers/waffle/with_waffle_options.tsx

Lines 77 to 78 in 344f895

changeGroupBy(initialUrlState.groupBy || initialWaffleOptionsState.groupBy);
changeNodeType(initialUrlState.nodeType || initialWaffleOptionsState.nodeType);

and remove the imports in

kibana/x-pack/plugins/infra/public/containers/waffle/with_waffle_options.tsx

Line 13 in 344f895

import { changeGroupBy, changeNodeType } from '../../store/local/waffle_options/actions';

@elasticmachine
Copy link
Contributor

💔 Build Failed

weltenwort
weltenwort approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the test failure seems to be unrelated

@simianhacker simianhacker merged commit f22d9cb into elastic:feature-infra-ui Oct 2, 2018
@simianhacker simianhacker deleted the fixing-waffle-options branch April 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

@XavierM XavierM Awaiting requested review from XavierM

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simianhacker @elasticmachine @weltenwort