Translate heatmap and heatmap_options #23812

tibmt · 2018-10-04T11:05:06Z

issue #23257
Translation of Heatmap visualization component

elasticmachine · 2018-10-04T11:05:08Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

pavel06081991

Great work! Please fix some comments

pavel06081991 · 2018-10-04T16:47:13Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

-            <strong>Required:</strong> You must specify at least one range.
+            <span 
+              i18n-id="kbnVislibVisTypes.controls.heatmapOptions.requiredTitle"
+              i18n-default-message="<strong>Required:</strong> You must specify at least one range."


use i18n-values for texts containing nested tags

pavel06081991 · 2018-10-04T16:47:24Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

-        >
-          Add Range
-        </button>
+          i18n-id="kbnVislibVisTypes.controls.heatmapOptions.addRangeButton"


addRangeButton => addRangeButtonLabel

pavel06081991 · 2018-10-04T16:47:54Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

-        <div class="text text-center text-info">Note: colors can be changed in the legend</div>
+        <div
+          class="text text-center text-info"
+          i18n-id="kbnVislibVisTypes.controls.heatmapOptions.noteTitle"


noteTitle => howToChangeColorsDescription

pavel06081991 · 2018-10-04T16:48:52Z

src/core_plugins/kbn_vislib_vis_types/public/editors/heatmap.html

+    <label
+      class="kuiSideBarFormRow__label"
+      for="enableHover"
+      i18n-id="kbnVislibVisTypes.editors.heatmap.HighlightLabel"


HighlightLabel => highlightLabel

pavel06081991 · 2018-10-04T16:49:28Z

src/core_plugins/kbn_vislib_vis_types/public/heatmap.js

@@ -86,7 +86,7 @@ export default function HeatmapVisType(Private) {
        {
          group: 'metrics',
          name: 'metric',
-          title: 'Value',
+          title: i18n('kbnVislibVisTypes.heatmap.valueTitle', { defaultMessage: 'Value' }),


valueTitle => metricTitle

pavel06081991 · 2018-10-04T16:49:39Z

src/core_plugins/kbn_vislib_vis_types/public/heatmap.js

@@ -97,23 +97,23 @@ export default function HeatmapVisType(Private) {
        {
          group: 'buckets',
          name: 'segment',
-          title: 'X-Axis',
+          title: i18n('kbnVislibVisTypes.heatmap.xAxisTitle', { defaultMessage: 'X-Axis' }),


xAxisTitle => segmentTitle

pavel06081991 · 2018-10-04T16:49:51Z

src/core_plugins/kbn_vislib_vis_types/public/heatmap.js

          min: 0,
          max: 1,
          aggFilter: ['!geohash_grid', '!filter']
        },
        {
          group: 'buckets',
          name: 'group',
-          title: 'Y-Axis',
+          title: i18n('kbnVislibVisTypes.heatmap.yAxisTitle', { defaultMessage: 'Y-Axis' }),


yAxisTitle => groupTitle

elasticmachine · 2018-10-05T12:46:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-05T16:29:49Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

pavel06081991 · 2018-10-08T08:45:02Z

@tibmt add 'kbnVislibVisTypes' to .i18nrc.json for CI to pass CI validation

pavel06081991 · 2018-10-08T08:49:39Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

-            <strong>Required:</strong> You must specify at least one range.
-          </p>
+          <p
+            i18n-id="kbnVislibVisTypes.controls.heatmapOptions.requiredTitle"


requiredTitle => specifiedRangeNumberWarningMessage

pavel06081991 · 2018-10-08T08:50:14Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

+            i18n-default-message="{icon} {required} You must specify at least one range."
+            i18n-values="{
+              icon: '<span class=&quot;kuiIcon fa-danger text-danger&quot;></span>',
+              required: '<strong>' + editorState.requiredDescription + '</strong>'


requiredDescription => requiredText

pavel06081991 · 2018-10-08T08:50:55Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.js

@@ -88,6 +88,10 @@ module.directive('heatmapOptions', function () {
      $scope.uiState.on('colorChanged', () => {
        $scope.customColors = true;
      });
+
+      $scope.editorState.requiredDescription = i18n('kbnVislibVisTypes.params.ranges.warning.requiredDescription', {
+        defaultMessage: 'Required:'


requiredDescription => requiredText

elasticmachine · 2018-10-08T12:36:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-08T13:04:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

pavel06081991

LGTM

elasticmachine · 2018-10-08T15:22:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

timroes · 2018-10-15T08:41:15Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html

+            i18n-id="kbnVislibVisTypes.controls.heatmapOptions.specifiedRangeNumberWarningMessage"
+            i18n-default-message="{icon} {required} You must specify at least one range."
+            i18n-values="{
+              icon: '<span class=\'kuiIcon fa-danger text-danger\'></span>',


Please use backtick strings to prevent escaping single quotes.

@timroes There is error if we will use backtick.

Angular does not allow use backtick strings in template

timroes · 2018-10-15T08:45:41Z

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.js

@@ -88,6 +88,10 @@ module.directive('heatmapOptions', function () {
      $scope.uiState.on('colorChanged', () => {
        $scope.customColors = true;
      });
+
+      $scope.editorState.requiredText = i18n('kbnVislibVisTypes.params.ranges.warning.requiredText', {


Don't push this to the editorState, but use the $scope directly.

elasticmachine · 2018-10-15T14:53:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

timroes

Code LGTM

Translation of Heatmap visualization component

Translate heatmap and heatmap_options

c53a407

Ttranslate heatmap.js file

1987975

pavel06081991 self-requested a review October 4, 2018 15:01

pavel06081991 suggested changes Oct 4, 2018

View reviewed changes

update translation of Heatmap Visualization Component

94baba3

Merge branch 'master' into feature/translations/heatmap

efc518f

pavel06081991 reviewed Oct 8, 2018

View reviewed changes

tibmt added 3 commits October 8, 2018 13:47

change some names

7dab330

add "kbnVislibVisTypes" to i18nnrc.json

3d228ac

use \' instead of "

b1944b4

Merge branch 'master' into feature/translations/heatmap

2ce007f

pavel06081991 approved these changes Oct 8, 2018

View reviewed changes

pavel06081991 requested a review from timroes October 8, 2018 15:00

timroes suggested changes Oct 15, 2018

View reviewed changes

update heatmap component

82ef951

pavel06081991 added the Project:i18n label Oct 16, 2018

tibmt added blocked and removed blocked labels Oct 17, 2018

timroes approved these changes Oct 18, 2018

View reviewed changes

tibmt merged commit 9a3414c into elastic:master Oct 18, 2018

tibmt deleted the feature/translations/heatmap branch October 18, 2018 11:17

tibmt added a commit to tibmt/kibana that referenced this pull request Oct 18, 2018

Translate heatmap and heatmap_options (elastic#23812)

b39d480

Translation of Heatmap visualization component

tibmt mentioned this pull request Oct 18, 2018

[6.x] Translate heatmap and heatmap_options (#23812) #24195

Merged

tibmt added the backported label Oct 18, 2018

tibmt added a commit that referenced this pull request Oct 18, 2018

Translate heatmap and heatmap_options (#23812) (#24195)

cc79398

Translation of Heatmap visualization component

maryia-lapata added v6.5.0 Feature:Heatmap Heatmap visualization labels Oct 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Translate heatmap and heatmap_options #23812

Translate heatmap and heatmap_options #23812

tibmt commented Oct 4, 2018 •

edited by pavel06081991

Loading

elasticmachine commented Oct 4, 2018

pavel06081991 left a comment

pavel06081991 Oct 4, 2018

pavel06081991 Oct 4, 2018

pavel06081991 Oct 4, 2018

pavel06081991 Oct 4, 2018

pavel06081991 Oct 4, 2018

pavel06081991 Oct 4, 2018

pavel06081991 Oct 4, 2018

elasticmachine commented Oct 5, 2018

elasticmachine commented Oct 5, 2018

pavel06081991 commented Oct 8, 2018

pavel06081991 Oct 8, 2018

pavel06081991 Oct 8, 2018

pavel06081991 Oct 8, 2018

elasticmachine commented Oct 8, 2018

elasticmachine commented Oct 8, 2018

pavel06081991 left a comment

elasticmachine commented Oct 8, 2018

timroes Oct 15, 2018

tibmt Oct 15, 2018 •

edited

Loading

tibmt Oct 18, 2018

timroes Oct 15, 2018

elasticmachine commented Oct 15, 2018

timroes left a comment

Translate heatmap and heatmap_options #23812

Translate heatmap and heatmap_options #23812

Conversation

tibmt commented Oct 4, 2018 • edited by pavel06081991 Loading

elasticmachine commented Oct 4, 2018

pavel06081991 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Oct 5, 2018

💚 Build Succeeded

elasticmachine commented Oct 5, 2018

💔 Build Failed

pavel06081991 commented Oct 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Oct 8, 2018

💔 Build Failed

elasticmachine commented Oct 8, 2018

💔 Build Failed

pavel06081991 left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 8, 2018

💚 Build Succeeded

Choose a reason for hiding this comment

tibmt Oct 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Oct 15, 2018

💚 Build Succeeded

timroes left a comment

Choose a reason for hiding this comment

tibmt commented Oct 4, 2018 •

edited by pavel06081991

Loading

tibmt Oct 15, 2018 •

edited

Loading