-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repositionOnScroll to popovers within the Inspector and the Index Management detail panel. #23856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Management detail panel.
cjcenizal
added
bug
Fixes for quality problems that affect the customer experience
:Management
v7.0.0
v6.5.0
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
labels
Oct 4, 2018
💔 Build Failed |
joshdover
approved these changes
Oct 5, 2018
bmcconaghy
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and fixes the issue shown in the PR description.
💔 Build Failed |
Jenkins test this |
💔 Build Failed |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v6.5.0
v7.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repositionOnScroll
address issues like this one:With this prop applied, the affected popovers will stick to the buttons from which they originate, when they're open and the user scrolls.