Show unsupported rollup query inside visualization #23863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to `Promise.all` rejecting on first failure * Show unsupported query search errors within visualization itself (aka ones not supported by rollup search)
|
I'm merging this to be reviewed with the main rollups PR as CJ is on vacation. This PR is for historical reference. |
💔 Build Failed |
jen-huang
added a commit
that referenced
this pull request
Oct 17, 2018
…e to `Promise.all` rejecting on first failure (#23863) * Show unsupported query search errors within visualization itself (aka ones not supported by rollup search)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let search errors bubble up instead of killing all search requests due to
Promise.allrejecting on first failure. This will show unsupported query search errors within visualization itself (aka ones not supported by rollup search). This is a better UX experience for dashboards with rollup items and non-rollup items.Dashboard with rollup and normal visualizations, no queries or filters:
Same dashboard with a filter that is not supported by rollup search:
Sample flight data dashboard (all non-rollup items) with an invalid query (
AND OR), this shows that error handling remains unchanged in other cases: