Fix timelion color error when filtering data #23876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins, test this |
💔 Build Failed |
spalger
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
timroes
assigned timroes, emmacunningham, markov00 and nickofthyme and unassigned timroes
# Conflicts: # src/core_plugins/timelion/server/series_functions/__tests__/color.js # src/core_plugins/timelion/server/series_functions/color.js
|
Jenkins, test this |
💚 Build Succeeded |
timroes
approved these changes
Aug 28, 2019
timroes
changed the title
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 28, 2019
…Series.length==1 (elastic#23876) * Fix 'Color not provided' error in case of more than 1 color and inputSeries.length==1 * Added test * Fix test * [master 71ee061] Merge branch master of github.com:elastic/kibana
|
Thank you a lot for providing this fix. Sorry that this slipped our radar and took an eternity to get this merged. I already backported the PR to be released in the next minor version of Kibana. 🙇♂️ |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15681
I did not do any of the below checklist, but since it is such a small fix, I at least wanted to share, see if you want to accept the PR.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatability, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers