Translations for Advanced Settings #23881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
Nox911
force-pushed
the
feature/translate-management-settings
branch
from
7ae2241
to
f8737ce
Compare
|
retest |
Nox911
force-pushed
the
feature/translate-management-settings
branch
from
4e71ee8
to
5fce58e
Compare
|
retest |
maryia-lapata
suggested changes
Oct 16, 2018
src/core_plugins/kibana/public/management/sections/settings/components/field/field.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/management/sections/settings/components/page_title/page_title.js
Show resolved
Hide resolved
src/core_plugins/kibana/public/management/sections/settings/components/search/search.js
Outdated
Show resolved
Hide resolved
src/core_plugins/kibana/public/management/sections/settings/components/search/search.js
Outdated
Show resolved
Hide resolved
maryia-lapata
changed the title
💔 Build Failed |
maryia-lapata
approved these changes
Oct 18, 2018
src/core_plugins/kibana/public/management/sections/settings/lib/get_category_name.js
Show resolved
Hide resolved
💚 Build Succeeded |
bmcconaghy
reviewed
Oct 19, 2018
| <FormattedMessage | ||
| defaultMessage="Be careful in here, these settings are for very advanced users only. Tweaks you make here can break large portions of Kibana. Some of these settings may be undocumented, unsupported or experimental. If a field has a default value, blanking the field will reset it to its default which may be unacceptable given other configuration directives. Deleting a custom setting will permanently remove it from Kibana's config." | ||
| id="kbn.management.settings.callOutCautionDescription" | ||
| values={Object {}} |
There was a problem hiding this comment.
question here about values={Object {}}. Seems unneeded.
There was a problem hiding this comment.
@bmcconaghy It's a snapshot of test. It generates automatically when tests is started.
💚 Build Succeeded |
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Oct 19, 2018
* translate kbn.management.advanced_settings * fix tests and update snapshots * fix tests * fix issues * fix id in get_category-name.js * Update unit test snapshot * update snapshot * Fix issues
maryia-lapata
added a commit
that referenced
this pull request
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate kbn -> management -> advanced_settings