Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations for Management -> Objects #23905

Merged
merged 20 commits into from
Oct 19, 2018
Merged

Translations for Management -> Objects #23905

merged 20 commits into from
Oct 19, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Oct 8, 2018

translate kbn management objects

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Oct 9, 2018

retest

@Nox911 Nox911 force-pushed the feature/translate-kbn-management-objects branch from bb2091e to 00d1f3e Compare October 9, 2018 09:26
pavel06081991
pavel06081991 reviewed Oct 9, 2018
View reviewed changes
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Please fix some comments

src/core_plugins/kibana/public/management/sections/objects/_view.html Outdated Show resolved Hide resolved
src/core_plugins/kibana/public/management/sections/objects/_view.html Outdated Show resolved Hide resolved
src/core_plugins/kibana/public/management/sections/objects/_view.html Outdated Show resolved Hide resolved
src/core_plugins/kibana/public/management/sections/objects/_view.html Outdated Show resolved Hide resolved
src/core_plugins/kibana/public/management/sections/objects/_view.html Outdated Show resolved Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js Outdated Show resolved Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js Outdated Show resolved Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js Outdated Show resolved Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js Outdated Show resolved Hide resolved
src/core_plugins/kibana/public/management/sections/objects/lib/resolve_saved_objects.js Outdated Show resolved Hide resolved
@Nox911
Copy link
Contributor Author

Nox911 commented Oct 16, 2018

retest

@maryia-lapata maryia-lapata changed the title Feature/translate kbn management objects Translations for Management -> Objects Oct 16, 2018
maryia-lapata
maryia-lapata suggested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just a couple of comments.

src/core_plugins/kibana/public/management/sections/objects/_view.js Outdated Show resolved Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js Outdated Show resolved Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js Outdated Show resolved Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js Outdated Show resolved Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/flyout/flyout.js Outdated Show resolved Hide resolved
...bana/public/management/sections/objects/components/objects_table/components/header/header.js Outdated Show resolved Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js Outdated Show resolved Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js Outdated Show resolved Hide resolved
..._plugins/kibana/public/management/sections/objects/components/objects_table/objects_table.js Outdated Show resolved Hide resolved
@maryia-lapata
Copy link
Contributor

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elastic elastic deleted a comment from elasticmachine Oct 18, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

maryia-lapata
maryia-lapata approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bmcconaghy
bmcconaghy reviewed Oct 19, 2018
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Did have a question about values={Object {}} that is used in a lot of the FormattedMessage usages.

src/core_plugins/kibana/public/management/sections/objects/_view.html Outdated Show resolved Hide resolved
.../sections/objects/components/objects_table/__jest__/__snapshots__/objects_table.test.js.snap
<FormattedMessage
defaultMessage="Cancel"
id="kbn.management.objects.objectsTable.deleteSavedObjectsConfirmModal.cancelButtonLabel"
values={Object {}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this empty object necessary?

Copy link
Contributor Author

@Nox911 Nox911 Oct 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmcconaghy It's a snapshot of test. It generates automatically when tests is started.

.../sections/objects/components/objects_table/__jest__/__snapshots__/objects_table.test.js.snap
defaultMessage="Delete"
id="kbn.management.objects.objectsTable.deleteSavedObjectsConfirmModal.deleteButtonLabel"
values={Object {}}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question re: empty object

Copy link
Contributor Author

@Nox911 Nox911 Oct 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmcconaghy It's a snapshot of test. It generates automatically when tests is started.

bmcconaghy
bmcconaghy approved these changes Oct 19, 2018
View reviewed changes
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata merged commit d8d2a18 into elastic:master Oct 19, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Oct 19, 2018
@Nox911 @maryia-lapata
Translations for Management -> Objects (elastic#23905)
8d6a816 
* fix tests and update snapshots

* fix id names

* fix test and update snapshots

* Update unit test snapshots

* fix issues

* Update snapshots

* Fix issues
@maryia-lapata maryia-lapata mentioned this pull request Oct 19, 2018
Merged
maryia-lapata added a commit that referenced this pull request Oct 19, 2018
@maryia-lapata
Translations for Management -> Objects (#23905) (#24280)
cd81a9e 
* fix tests and update snapshots

* fix id names

* fix test and update snapshots

* Update unit test snapshots

* fix issues

* Update snapshots

* Fix issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel06081991 pavel06081991 pavel06081991 left review comments

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@bmcconaghy bmcconaghy bmcconaghy approved these changes

Assignees
No one assigned
Labels
backported Project:i18n v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nox911 @elasticmachine @maryia-lapata @bmcconaghy @pavel06081991