Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] CCR UI fixes #23922

Merged
merged 3 commits into from
Oct 18, 2018

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Oct 9, 2018

This PR contains fixes for bugs or optimizations discovered while preparing for the CCR demo.

The changes are:

  1. On the shard detail, flip the ordering of the graphs so the Ops delay graph appears first. As a result of this, we also changed the ordering of the columns in the main ccr page table to show this order: Sync Lag (ops), Last fetch time, Ops synced (from Ops synced, Last fetch time, Sync Lag (ops))

screen shot 2018-10-17 at 12 33 33 pm

  1. Fix a bug with the Last fetch time where it was attempting to perform a delta of max and min across the time period, but that data is not a counter and we just need to grab the latest document's value and render that.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chrisronline
Copy link
Contributor Author

retest

@chrisronline
Copy link
Contributor Author

error:
{ Error: Command failed: convert -density 300 "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/x-pack/test/functional/screenshots/session/dashboard_print_baseline.pdf[0]" "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/x-pack/test/functional/screenshots/session/dashboard_print_baseline-0.png"
convert: not authorized /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/x-pack/test/functional/screenshots/session/dashboard_print_baseline.pdf' @ error/constitute.c/ReadImage/412. convert: no images defined /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/kibana/x-pack/test/functional/screenshots/session/dashboard_print_baseline-0.png' @ error/convert.c/ConvertImageCommand/3210.

Random failure

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chrisronline
Copy link
Contributor Author

14:13:35 error An unexpected error occurred: "https://registry.yarnpkg.com/esrecurse/-/esrecurse-4.2.1.tgz: Request failed "502 Bad Gateway"".
14:13:35 info If you think this is a bug, please open a bug report with the information provided in "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/kibana/packages/kbn-eslint-import-resolver-kibana/yarn-error.log".

Random...

@chrisronline
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chrisronline
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisronline
Copy link
Contributor Author

@bleskes Can you verify these changes? You know about nearly all of them so should be straight forward

@bleskes
Copy link
Contributor

bleskes commented Oct 17, 2018

@chrisronline lgtm

@chrisronline chrisronline merged commit f382ee2 into elastic:master Oct 18, 2018
@chrisronline chrisronline deleted the monitoring/ccr_demo_fixes branch October 18, 2018 13:06
chrisronline added a commit to chrisronline/kibana that referenced this pull request Oct 18, 2018
chrisronline added a commit that referenced this pull request Oct 18, 2018
@chrisronline
Copy link
Contributor Author

Backport:

6.x: 0d02162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants