[Ingest UI] Add Nginx Metrics to Detail Pages #23924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
simianhacker
changed the title
💔 Build Failed |
skh
reviewed
Oct 16, 2018
| } | ||
|
|
||
| export interface InfraMetricModel { | ||
| id: string; | ||
| requires: string[]; | ||
| index_pattern: string; | ||
| index_pattern: string | string[]; |
There was a problem hiding this comment.
Can you explain what these changes do and why they were necessary?
There was a problem hiding this comment.
The index argument for the Elasticsearch client can be both a string or an array of strings. Originally it only worked with one index pattern but I realized that there are times we need to do 2.
skh
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Nginx metrics to the detail pages. There will be a follow up PR that will add and hide the Nginx sections to the nodes that have those capabilities. For now it will show up on all the pages with empty data.