block user from proceeding when she has no permissions to view rollup… #24024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
jen-huang
approved these changes
Oct 15, 2018
x-pack/plugins/rollup/public/crud_app/sections/job_list/job_list.js
Outdated
Show resolved
Hide resolved
jen-huang
pushed a commit
that referenced
this pull request
Oct 17, 2018
#24024) * block user from proceeding when she has no permissions to view rollup jobs * removing stray console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a no permission screen to the rollup CRUD UI when the user gets back a 403 error from the listJobs API call.
This change can be verified by adding a user with kibana_user permissions and then logging in as that user and navigating to the rollup jobs section in management.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature additition or change that requires a release note and was labeled appropriately