Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chrome instead of IE for karma tests on windows #24053

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

liza-mae
Copy link
Contributor

Use default Chrome instead of IE for karma tests. Addresses #22431.

Part of #21315

@liza-mae liza-mae self-assigned this Oct 15, 2018
@liza-mae liza-mae changed the title Use chrome instead of IE for karma on windows Use chrome instead of IE for karma tests on windows Oct 15, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@liza-mae
Copy link
Contributor Author

liza-mae commented Oct 16, 2018

CI failure is not related to this PR and is a known issue
X-Pack Spaces API Integration Tests -- security_and_spaces.x-pack/test/spaces_api_integration/security_and_spaces/apis/delete·ts.spaces api with security delete superuser from the default space should return 204
Stack Trace
{ Error: expected [ { key: 'default',
doc_count: 4,
countByType:
{ doc_count_error_upper_bound: 0,
sum_other_doc_count: 0,
buckets: [Object] } },
{ key: 'space_1',
doc_count: 1,
countByType:
{ doc_count_error_upper_bound: 0,
sum_other_doc_count: 0,
buckets: [Object] } } ] to sort of equal [ { key: 'default',
doc_count: 3,
countByType:
{ doc_count_error_upper_bound: 0,
sum_other_doc_count: 0,
buckets: [Object] } },
{ doc_count: 1,
key: 'space_1',
countByType:
{ doc_count_error_upper_bound: 0,
sum_other_doc_count: 0,
buckets: [Object] } } ]
at Assertion.assert (node_modules/expect.js/index.js:96:13)
at Assertion.eql (node_modules/expect.js/index.js:230:10)
at expectEmptyResult (test/spaces_api_integration/common/suites/delete.ts:86:41)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
actual: '[\n {\n "countByType": {\n "buckets": [\n {\n "doc_count": 2\n "key": "space"\n }\n {\n "doc_count": 1\n "key": "config"\n }\n {\n "doc_count": 1\n "key": "dashboard"\n }\n ]\n "doc_count_error_upper_bound": 0\n "sum_other_doc_count": 0\n }\n "doc_count": 4\n "key": "default"\n }\n {\n "countByType": {\n "buckets": [\n {\n "doc_count": 1\n "key": "dashboard"\n }\n ]\n "doc_count_error_upper_bound": 0\n "sum_other_doc_count": 0\n }\n "doc_count": 1\n "key": "space_1"\n }\n]',
expected: '[\n {\n "countByType": {\n "buckets": [\n {\n "doc_count": 2\n "key": "space"\n }\n {\n "doc_count": 1\n "key": "dashboard"\n }\n ]\n "doc_count_error_upper_bound": 0\n "sum_other_doc_count": 0\n }\n "doc_count": 3\n "key": "default"\n }\n {\n "countByType": {\n "buckets": [\n {\n "doc_count": 1\n "key": "dashboard"\n }\n ]\n "doc_count_error_upper_bound": 0\n "sum_other_doc_count": 0\n }\n "doc_count": 1\n "key": "space_1"\n }\n]',
showDiff: true }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants