[ML] Fixes clean up of multi-bucket markers on Single Metric chart up… #24080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
bug
peteharverson
requested review from
walterra,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
jgowdyelastic
approved these changes
Oct 16, 2018
💔 Build Failed |
|
retest |
💔 Build Failed |
peteharverson
force-pushed
the
ml-multi-bucket-marker-select
branch
from
85c547d to
25ef23b
Compare
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Oct 17, 2018
peteharverson
added a commit
that referenced
this pull request
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue introduced in #23746 which could cause misplaced multi-bucket anomaly markers to appear in the Single Metric Viewer chart:
Previously when the chart was redrawn, for example by changing the position or extending the range of the selection 'slider', the d3 selection used to clean out previously rendered chart markers was not specific enough for the 'single bucket' or 'multi-bucket' markers, so old markers could end up being re-rendered on the chart. This has been fixed by using a specific
multi-bucketclass for the d3 selection of the multi-bucket markers.The fix was extended to the Anomaly Explorer single metric chart for consistency although these charts were not affected by the same issue as they are completely redrawn on container resize.
The size of the 'cross' symbol used for the multi-bucket markers has also been dropped slightly to reduce the visual impact of these markers, giving them dimensions similar in size to the 'single bucket' markers.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature additition or change that requires a release note and was labeled appropriately(non-issue, only introduced by [ML] Indicate multi-bucket anomalies in results dashboards #23746