[ML] Add button for refreshing job list without full page refresh. #24084
Conversation
alvarezmelissa87
added
release_note:enhancement
review
v7.0.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
|
Just a question about the general structure of the code: Since we have the button for a new job as a separate component |
|
@peteharverson - great catch! Fixed that and updated the screenshot. 👍 |
|
Good one, @walterra - I was just thinking that would make it super easy to test, too 👍 I'll go ahead and do that |
| return ( | ||
| <React.Fragment> | ||
| <JobStatsBar | ||
| setUpdateJobStats={this.setUpdateJobStats} |
There was a problem hiding this comment.
couldn't the JobStatsBar now receive the whole jobsSummaryList as a prop and then update itself whenever it changes?
It would remove the need for setUpdateJobStats and unsetUpdateJobStats and make the code a lot simpler.
JobStatsBar could then call createJobStats in getDerivedStateFromProps and create the job stats
| /> | ||
| <div className="job-management"> | ||
| <NodeAvailableWarning /> | ||
| <header> |
There was a problem hiding this comment.
nit, to keep this cleaner, could this whole header be moved to a component that takes in onRefreshClick and isRefreshing ?
There was a problem hiding this comment.
I thought about that but I think it's probably okay to keep each of them separate (the node warning, new button, and refresh button) since they don't share anything and each of them can be tested on their own. 🤔
💔 Build Failed |
💔 Build Failed |
|
@walterra, @jgowdyelastic - updated from the comments! Would really appreciate if you could take one last look. Thanks! 😄 |
💔 Build Failed |
|
retest |
💔 Build Failed |
alvarezmelissa87
force-pushed
the
ml-refresh-job-list
branch
from
5064783 to
63efcca
Compare
💚 Build Succeeded |
…lastic#24084) * Add refresh button for job list * Show load icon while refreshing * Move view build logic to jobsListView * Align job action buttons in ui * Extract RefreshJobsListButton component * update jobStatsBar to take list as prop
Summary
Related issue: #17983
New:
Add
Refreshbutton (next toCreate New Job) that will refresh job list without a full page refresh.Refactor:
Keep
jobs.jsas a simple display component to pass to the jobsPage directive.Now,
jobs_list_view.jspulls inJobStatsBar,NodeAvailableWarning, and the addedEuiButtonEmptyRefresh button.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature additition or change that requires a release note and was labeled appropriately