[5.6] - Switch to using a fork #24086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #23422 to the 5.6 branch.
Implementation Notes
The original fix for #23422 takes advantage of yarn aliases to link to the forked version of lodash. Kibana 5.x does not use yarn, but rather npm. npm does not support aliases, so we are not able to cleanly backport this change.
We first attempted to point to the git repository directly (
elastic/lodash@3.10.1-npm-kibana1), but itspackage.jsoncorrectly names the package@elastic/lodash. When installing this package, we end up with an@elastic/lodashdirectory innode_modules, rather than alodashdirectory. Since we are missing thelodashdirectory, all import/require statements forlodashfail.This PR solves that by publishing a nearly identical branch which is named
lodashinstead of@elastic/lodash: https://github.com/elastic/lodash/tree/3.10.1-npm-kibana1-5.6.This is admittedly a hacky solution, but this is a temporary fix, and we do not anticipate making many/any changes to the 'lodash' fork for 5.6.