Handle exit code of 1 when terminating Kibana process on windows #24151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liza-mae
changed the title
💔 Build Failed |
💔 Build Failed |
|
CI Failure is not related to this PR and is a known issue |
💔 Build Failed |
💚 Build Succeeded |
spalger
reviewed
Oct 19, 2018
Co-Authored-By: liza-mae <ldayoub@gmail.com>
💚 Build Succeeded |
spalger
approved these changes
Oct 22, 2018
liza-mae
added a commit
to liza-mae/kibana
that referenced
this pull request
Oct 22, 2018
…stic#24151) * Handle exit code of 1 on windows * Remove space to fix intake failure * Update using solution from Spencer * Update debug log message Co-Authored-By: liza-mae <ldayoub@gmail.com>
liza-mae
added a commit
to liza-mae/kibana
that referenced
this pull request
Oct 22, 2018
…stic#24151) * Handle exit code of 1 on windows * Remove space to fix intake failure * Update using solution from Spencer * Update debug log message Co-Authored-By: liza-mae <ldayoub@gmail.com>
This was referenced Oct 22, 2018
liza-mae
added a commit
that referenced
this pull request
Oct 23, 2018
) (#24357) * Handle exit code of 1 on windows * Remove space to fix intake failure * Update using solution from Spencer * Update debug log message Co-Authored-By: liza-mae <ldayoub@gmail.com>
liza-mae
added a commit
that referenced
this pull request
Oct 23, 2018
) (#24358) * Handle exit code of 1 on windows * Remove space to fix intake failure * Update using solution from Spencer * Update debug log message Co-Authored-By: liza-mae <ldayoub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22312, part of #21315.
Similar fix to #23441