[Logstash] [Pipeline Viewer] Improve LS monitoring accessibility #24169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
Project:Accessibility
v7.0.0
Team:Logstash
Team:Monitoring
💔 Build Failed |
|
jenkins test this |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
Backported to: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #18065
The accessibility of the Pipeline Viewer was already greatly improved with the changes we added in #18597 for 6.4.0, but it can be improved with the proper addition of aria-labels for the buttons on the view.
With regards to tab order, @snide and I confirmed that everything looks fine with it, and it should because the view is composed exclusively of EUI components.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11All the components in question are EUI-maintained- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportNo text was added, the labels use the name fields.- [ ] Documentation was added for features that require explanation or tutorialsNo functionality was added, aside from increasing the utility of screen readersFor maintainers
Testing this PR
The updated snapshots should demonstrate the needed labels being rendered, but if you want to actually see the view rendering these I'm happy to help stand up a LS instance.
Alternatively, here's an example of each of the button types rendering the appropriate aria-label attribute:
cc @AlonaNadler