[BeatsCM] check for security after license, add support for standard license #24210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Oct 18, 2018
ruflin
approved these changes
Oct 18, 2018
|
There is not a way (that I know of) to check this in an integration test. I have been working on unit tests for this entire file, but they are not yet ready. |
💚 Build Succeeded |
mattapperson
added a commit
that referenced
this pull request
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things.
Fixes a bug where an OSS or basic license kibana, with
xpack.security.enabled=falseset in settings would throw an error bar in kibana due to checking for security before a license.Adds a cloud
standardlicense support https://github.com/elastic/dev/issues/1034#issuecomment-430720588