Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] functional browser test for infraops page #24248

Merged

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Oct 18, 2018

Summary

This adds a basic functional browser test for the following aspects of the InfraOps home page:

  • displays a specific empty prompt when no metrics indices are present
  • displays a waffle map when data are available at a given time
  • displays a specific empty prompt when no data are available at a given time

Checklist

For maintainers

@weltenwort weltenwort added :Ingest UI Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort labels Oct 18, 2018
@weltenwort weltenwort self-assigned this Oct 18, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort requested a review from skh October 19, 2018 11:50
Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adequately complains when I break the tested page 👍

Just one question about folder naming but that can, if necessary at all, be done in one PR when we've merged all the tests.

@@ -0,0 +1,46 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to the other open PRs with tests as well: we should probably keep in sync with the plugin folder stucture and call the folder infra instead of infraops for now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm always in favor of consistency 😉 If we want to agree on infra for now (possibly ingest after #24242), I can change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I change mine too.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort force-pushed the infra-ui-test-integration-home-page branch from 29c5520 to a31bd01 Compare October 19, 2018 20:12
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort merged commit 744edd9 into elastic:master Oct 22, 2018
weltenwort added a commit to weltenwort/kibana that referenced this pull request Oct 23, 2018
weltenwort added a commit that referenced this pull request Oct 23, 2018
…24388)

Backports the following commits to 6.x:
 - [Infra UI] functional browser test for infraops page  (#24248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort v6.5.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants