Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade husky #24432

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Upgrade husky #24432

merged 2 commits into from
Oct 23, 2018

Conversation

liza-mae
Copy link
Contributor

@liza-mae liza-mae commented Oct 23, 2018

To fix a problem on Windows, part of #21315

[5/5] Building fresh packages...
error C:\Users\vagrant\kibana\node_modules\husky: Command failed.
Exit code: 1
Command: node ./bin/install.js
Arguments:
Directory: C:\Users\vagrant\kibana\node_modules\husky
Output:
husky
setting up hooks in .git/hooks/
path.js:28
throw new TypeError('Path must be a string. Received ' + inspect(path));
^

TypeError: Path must be a string. Received null
at assertPath (path.js:28:11)
at Object.join (path.js:489:7)
at Object.create (C:\Users\vagrant\kibana\node_modules\husky\src\index.js:41:27)
at C:\Users\vagrant\kibana\node_modules\husky\bin\install.js:12:11
at C:\Users\vagrant\kibana\node_modules\husky\src\index.js:14:9
at ChildProcess.exithandler (child_process.js:282:5)
at emitTwo (events.js:126:13)
at ChildProcess.emit (events.js:214:7)
at maybeClose (internal/child_process.js:925:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5)
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

[bootstrap] failed:

Error: Command failed: yarn install --check-files --non-interactive --mutex file
at makeError (C:\Users\vagrant\kibana\packages\kbn-pm\dist\index.js:35524:9)
at Promise.all.then.arr (C:\Users\vagrant\kibana\packages\kbn-pm\dist\index.js:35629:16)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae merged commit 7fbcd6e into elastic:master Oct 23, 2018
@liza-mae liza-mae deleted the liza-updpkg/husky-upgrade branch October 23, 2018 22:19
liza-mae added a commit to liza-mae/kibana that referenced this pull request Oct 23, 2018
* Upgrade husky

* Add yarn.lock
liza-mae added a commit to liza-mae/kibana that referenced this pull request Oct 23, 2018
* Upgrade husky

* Add yarn.lock
liza-mae added a commit that referenced this pull request Oct 23, 2018
* Upgrade husky

* Add yarn.lock
liza-mae added a commit that referenced this pull request Oct 24, 2018
* Upgrade husky

* Add yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants