Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kbn-pm README for workspaces #25766

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

joshdover
Copy link
Contributor

Summary

Updates kbn-pm's README to reflect the changes from #24095.

@joshdover joshdover added review Team:Operations Team label for Operations Team v7.0.0 v6.6.0 labels Nov 15, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

dependencies. This gave us the control we wanted, and it fits nicely into our
context (e.g. where publishing to npm isn't necessarily something we want to
do).
In the end we decided to build our own tool, based on Yarn, and `link:`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we still using link dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For external plugins, yes.

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit 8e21a1b into elastic:master Nov 16, 2018
@joshdover joshdover deleted the update-kbn-pm-readme branch November 16, 2018 14:20
joshdover added a commit to joshdover/kibana that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Operations Team label for Operations Team v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants