-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use canvas pipeline in visualize #25996
Merged
ppisljar
merged 39 commits into
elastic:master
from
ppisljar:visualize_canvas_pipeline2
Dec 10, 2018
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
8fcae1c
Resolve merge conflicts
lukeelmers ffaaafc
Fix broken imports
lukeelmers 3e1ecec
adding canvas functions
ppisljar 7150369
using pipeline in visualize
ppisljar 44e9a20
skipping irrelevant tests
ppisljar 55478d4
fixing test
ppisljar 2328428
fixing based on review from tim
ppisljar 7ff1284
i18n
ppisljar de13cb2
Fix broken i18n calls in core_plugins/interpreter.
lukeelmers 7f7ece6
fix broken merge
ppisljar 134321c
review feedback
ppisljar 04f3c3a
support for custom request and response handlers
ppisljar 338f08b
fixing markdown
ppisljar b00c64a
Rewrite pipeline helpers in ts, add WIP unit tests.
lukeelmers 1d9d35b
changing the syntax for passing multiple metrics/buckets
ppisljar b43de6f
initialContext handler function
ppisljar e1f9119
cleaning up pipeline_data_loader
ppisljar 6d5b8a5
Improve TS and autofix trailing spaces
41fb681
applying tim's feedback
ppisljar 631c748
Add Schemas interface, finish buildVisPipeline tests.
lukeelmers 79eca45
Add remaining tests for build pipeline helper.
lukeelmers e8dbf07
fixing
ppisljar 0d8f843
Merge branch 'master' into visualize_canvas_pipeline2
ppisljar 4eb8b74
Merge branch 'master' into visualize_canvas_pipeline2
ppisljar 9c00335
review feedback
ppisljar ae85fa3
Merge branch 'master' into visualize_canvas_pipeline2
ppisljar 980cdca
Merge branch 'master' into visualize_canvas_pipeline2
ppisljar af839d3
fixing merge master
ppisljar d8ebcfb
Merge branch 'master' into visualize_canvas_pipeline2
ppisljar 1b5bdce
fixing merge master
ppisljar 851ef35
split table row/column
ppisljar e7c63f1
updating based on tim's review
ppisljar 995e241
fixing escaping issue
ppisljar c50ead2
updating canvas setAppReady
ppisljar 01fbb84
removing multi: false from args
ppisljar fcd0f6a
named functions
ppisljar 319d7c1
renaming getInitializedFunctions
ppisljar 0a69a2e
Merge branch 'master' into visualize_canvas_pipeline2
ppisljar 6c13b48
Merge branch 'master' into visualize_canvas_pipeline2
ppisljar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import { populateBrowserRegistries } from '@kbn/interpreter/public'; | ||
import { populateBrowserRegistries, isInterpreterInitialized } from '@kbn/interpreter/public'; | ||
import { connect } from 'react-redux'; | ||
import { compose, withProps } from 'recompose'; | ||
import { getAppReady, getBasePath } from '../../state/selectors/app'; | ||
|
@@ -49,6 +49,7 @@ const mapDispatchToProps = dispatch => ({ | |
// initialize the socket and interpreter | ||
loadPrivateBrowserFunctions(); | ||
await populateBrowserRegistries(types, basePath); | ||
await isInterpreterInitialized(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The fact we're not doing anything with the result indicates this method is incorrectly named, (see above, as well). |
||
|
||
// set app state to ready | ||
dispatch(appReady()); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A method should not start with
is
unless it returnsboolean
. ConsidergetInitializedFunctions
or returning!!functionList
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On further review, since
functionList
is a Promise,!!functionList
will always betrue
. This method name and logic should be refactored to reflect precisely what you're trying to do... imagine if you applied TypeScript to this file, (which will happen soon, right?)