dont use schemas in aggconfigs to output dsl #26010
Conversation
- keep mapBounds in aggconfig json - dont use schemas in aggconfigs to output dsl - pass global filters from editor to visualize
ppisljar
added
review
v7.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app |
| @@ -141,6 +141,8 @@ uiModules | |||
| self.visState | |||
| ); | |||
|
|
|||
| self.vis.savedSearchId = self.savedSearchId; | |||
There was a problem hiding this comment.
we will need this later, but as we discussed with tim that we want to keep both rendering infrastructures for a while, i want to add small things like this in separately from the main PR that will introduce rendering thru canvas pipeline
| @@ -94,7 +94,7 @@ describe('Geohash Agg', () => { | |||
|
|
|||
| describe('precision parameter', () => { | |||
|
|
|||
| const PRECISION_PARAM_INDEX = 6; | |||
| const PRECISION_PARAM_INDEX = 7; | |||
There was a problem hiding this comment.
this changed due to added mapBounds parameter
| @@ -100,6 +100,11 @@ export const geoHashBucketAgg = new BucketAggType({ | |||
| default: [0, 0], | |||
| write: _.noop | |||
| }, | |||
| { | |||
| name: 'mapBounds', | |||
There was a problem hiding this comment.
we are adding this here, so mapBounds is part of json output for this aggregation. We are gonna need this in the pipeline.
| @@ -52,7 +52,7 @@ class AggConfigs extends IndexedArray { | |||
|
|
|||
| super({ | |||
| index: ['id'], | |||
| group: ['schema.group', 'type.name', 'schema.name'], | |||
| group: ['schema.group', 'type.name', 'type.type', 'schema.name'], | |||
There was a problem hiding this comment.
we should not use schema.group for outputing the dsl (in the pipeline we won't have schema definitions at that time). this should already be removed, seems this single thing slipped then.
💔 Build Failed |
|
retest |
💚 Build Succeeded |
💚 Build Succeeded |
Summary
A couple of small fixes in visualize in preparation for #25996
QA: no functional changes
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately