[Canvas] Fix: IE11 SVG elements have neither classList nor parentElement #26035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfera
added
the
Team:Presentation
|
Pinging @elastic/kibana-canvas |
|
No issues code-wise, if it works, ship it. |
💚 Build Succeeded |
This was referenced Nov 26, 2018
monfera
added a commit
to monfera/kibana
that referenced
this pull request
Nov 26, 2018
monfera
added a commit
to monfera/kibana
that referenced
this pull request
Nov 26, 2018
monfera
added a commit
that referenced
this pull request
Nov 26, 2018
monfera
added a commit
that referenced
this pull request
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #25874
No crash here, element interacts fine (looks choppier due to VM)
Root cause of the problem was that SVG elements in IE11 have neither classList nor parentElement
Thanks @bhavyarm for the report!
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately