[i18n] Translate untranslated labels

.i18nrc.json

@@ -28,6 +28,7 @@
     "xpack.rollupJobs": "x-pack/plugins/rollup",
     "xpack.searchProfiler": "x-pack/plugins/searchprofiler",
     "xpack.security": "x-pack/plugins/security",
+    "xpack.spaces": "x-pack/plugins/spaces",
     "xpack.watcher": "x-pack/plugins/watcher"
   },
   "exclude": [

src/legacy/core_plugins/console/public/hacks/register.js

@@ -18,10 +18,13 @@
  */
 
 import { DevToolsRegistryProvider } from 'ui/registry/dev_tools';
+import { i18n } from '@kbn/i18n';
 
 DevToolsRegistryProvider.register(() => ({
   order: 1,
   name: 'console',
-  display: 'Console',
+  display: i18n.translate('console.consoleDisplayName', {
+    defaultMessage: 'Console'
+  }),
   url: '#/dev_tools/console'
 }));

src/legacy/core_plugins/console/public/src/controllers/sense_top_nav_controller.js

@@ -26,12 +26,18 @@ export function SenseTopNavController(Private, i18n) {
   const controller = new KbnTopNavController([
     {
       key: 'welcome',
+      label: i18n('console.topNav.welcomeTabLabel', {
+        defaultMessage: 'Welcome'
+      }),
       hideButton: true,
       template: `<sense-welcome></sense-welcome>`,
       testId: 'consoleWelcomeButton',
     },
     {
       key: 'history',
+      label: i18n('console.topNav.historyTabLabel', {
+        defaultMessage: 'History'
+      }),
       description: i18n('console.topNav.historyTabDescription', {
         defaultMessage: 'History',
       }),
@@ -40,6 +46,9 @@ export function SenseTopNavController(Private, i18n) {
     },
     {
       key: 'settings',
+      label: i18n('console.topNav.settingsTabLabel', {
+        defaultMessage: 'Settings'
+      }),
       description: i18n('console.topNav.settingsTabDescription', {
         defaultMessage: 'Settings',
       }),
@@ -48,6 +57,9 @@ export function SenseTopNavController(Private, i18n) {
     },
     {
       key: 'help',
+      label: i18n('console.topNav.helpTabLabel', {
+        defaultMessage: 'Help'
+      }),
       description: i18n('console.topNav.helpTabDescription', {
         defaultMessage: 'Help',
       }),

src/legacy/core_plugins/kibana/public/discover/controllers/discover.js

@@ -191,17 +191,19 @@ function discoverController(
   };
 
   $scope.topNavMenu = [{
-    key: i18n('kbn.discover.localMenu.localMenu.newSearchTitle', {
-      defaultMessage: 'new',
+    key: 'new',
+    label: i18n('kbn.discover.localMenu.localMenu.newSearchTitle', {
+      defaultMessage: 'New',
     }),
     description: i18n('kbn.discover.localMenu.newSearchDescription', {
       defaultMessage: 'New Search',
     }),
     run: function () { kbnUrl.change('/discover'); },
     testId: 'discoverNewButton',
   }, {
-    key: i18n('kbn.discover.localMenu.saveTitle', {
-      defaultMessage: 'save',
+    key: 'save',
+    label: i18n('kbn.discover.localMenu.saveTitle', {
+      defaultMessage: 'Save',
     }),
     description: i18n('kbn.discover.localMenu.saveSearchDescription', {
       defaultMessage: 'Save Search',
@@ -237,8 +239,9 @@ function discoverController(
       showSaveModal(saveModal);
     }
   }, {
-    key: i18n('kbn.discover.localMenu.openTitle', {
-      defaultMessage: 'open',
+    key: 'open',
+    label: i18n('kbn.discover.localMenu.openTitle', {
+      defaultMessage: 'Open',
     }),
     description: i18n('kbn.discover.localMenu.openSavedSearchDescription', {
       defaultMessage: 'Open Saved Search',
@@ -252,8 +255,9 @@ function discoverController(
       });
     }
   }, {
-    key: i18n('kbn.discover.localMenu.shareTitle', {
-      defaultMessage: 'share',
+    key: 'share',
+    label: i18n('kbn.discover.localMenu.shareTitle', {
+      defaultMessage: 'Share',
     }),
     description: i18n('kbn.discover.localMenu.shareSearchDescription', {
       defaultMessage: 'Share Search',
@@ -276,8 +280,9 @@ function discoverController(
       });
     }
   }, {
-    key: i18n('kbn.discover.localMenu.inspectTitle', {
-      defaultMessage: 'inspect',
+    key: 'inspect',
+    label: i18n('kbn.discover.localMenu.inspectTitle', {
+      defaultMessage: 'Inspect',
     }),
     description: i18n('kbn.discover.localMenu.openInspectorForSearchDescription', {
       defaultMessage: 'Open Inspector for search',

src/legacy/core_plugins/timelion/public/app.js

@@ -114,35 +114,39 @@ app.controller('timelion', function (
   const savedSheet = $route.current.locals.savedSheet;
 
   $scope.topNavMenu = [{
-    key: i18n('timelion.topNavMenu.newSheetButtonLabel', {
-      defaultMessage: 'new',
+    key: 'new',
+    label: i18n('timelion.topNavMenu.newSheetButtonLabel', {
+      defaultMessage: 'New',
     }),
     description: i18n('timelion.topNavMenu.newSheetButtonAriaLabel', {
       defaultMessage: 'New Sheet',
     }),
     run: function () { kbnUrl.change('/'); },
     testId: 'timelionNewButton',
   }, {
-    key: i18n('timelion.topNavMenu.addChartButtonLabel', {
-      defaultMessage: 'add',
+    key: 'add',
+    label: i18n('timelion.topNavMenu.addChartButtonLabel', {
+      defaultMessage: 'Add',
     }),
     description: i18n('timelion.topNavMenu.addChartButtonAriaLabel', {
       defaultMessage: 'Add a chart',
     }),
     run: function () { $scope.newCell(); },
     testId: 'timelionAddChartButton',
   }, {
-    key: i18n('timelion.topNavMenu.saveSheetButtonLabel', {
-      defaultMessage: 'save',
+    key: 'save',
+    label: i18n('timelion.topNavMenu.saveSheetButtonLabel', {
+      defaultMessage: 'Save',
     }),
     description: i18n('timelion.topNavMenu.saveSheetButtonAriaLabel', {
       defaultMessage: 'Save Sheet',
     }),
     template: require('plugins/timelion/partials/save_sheet.html'),
     testId: 'timelionSaveButton',
   }, {
-    key: i18n('timelion.topNavMenu.deleteSheetButtonLabel', {
-      defaultMessage: 'delete',
+    key: 'delete',
+    label: i18n('timelion.topNavMenu.deleteSheetButtonLabel', {
+      defaultMessage: 'Delete',
     }),
     description: i18n('timelion.topNavMenu.deleteSheetButtonAriaLabel', {
       defaultMessage: 'Delete current sheet',
@@ -185,26 +189,29 @@ app.controller('timelion', function (
     },
     testId: 'timelionDeleteButton',
   }, {
-    key: i18n('timelion.topNavMenu.openSheetButtonLabel', {
-      defaultMessage: 'open',
+    key: 'open',
+    label: i18n('timelion.topNavMenu.openSheetButtonLabel', {
+      defaultMessage: 'Open',
     }),
     description: i18n('timelion.topNavMenu.openSheetButtonAriaLabel', {
       defaultMessage: 'Open Sheet',
     }),
     template: require('plugins/timelion/partials/load_sheet.html'),
     testId: 'timelionOpenButton',
   }, {
-    key: i18n('timelion.topNavMenu.optionsButtonLabel', {
-      defaultMessage: 'options',
+    key: 'options',
+    label: i18n('timelion.topNavMenu.optionsButtonLabel', {
+      defaultMessage: 'Options',
     }),
     description: i18n('timelion.topNavMenu.optionsButtonAriaLabel', {
       defaultMessage: 'Options',
     }),
     template: require('plugins/timelion/partials/sheet_options.html'),
     testId: 'timelionOptionsButton',
   }, {
-    key: i18n('timelion.topNavMenu.helpButtonLabel', {
-      defaultMessage: 'help',
+    key: 'help',
+    label: i18n('timelion.topNavMenu.helpButtonLabel', {
+      defaultMessage: 'Help',
     }),
     description: i18n('timelion.topNavMenu.helpButtonAriaLabel', {
       defaultMessage: 'Help',

src/ui/public/kbn_top_nav/kbn_top_nav.html

@@ -42,7 +42,11 @@
     class="kuiLocalDropdown"
     ng-show="kbnTopNav.rendered"
   >
-    <button class="kuiLocalDropdownCloseButton" ng-click="kbnTopNav.close()" aria-label="Close">
+    <button
+      class="kuiLocalDropdownCloseButton"
+      ng-click="kbnTopNav.close()"
+      aria-label="{{ ::'common.ui.topNav.closeAriaLabel' | i18n: { defaultMessage: 'Close' } }}"
+    >
       <span class="kuiIcon fa-chevron-circle-up"></span>
     </button>
     <div id="template_wrapper">

src/ui/public/kbn_top_nav/kbn_top_nav_controller.js

@@ -22,6 +22,7 @@ import { capitalize, isArray, isFunction, get } from 'lodash';
 import chrome from '../chrome';
 import filterTemplate from '../chrome/config/filter.html';
 import intervalTemplate from '../chrome/config/interval.html';
+import { i18n } from '@kbn/i18n';
 
 export function KbnTopNavControllerProvider($compile) {
   return class KbnTopNavController {
@@ -89,9 +90,12 @@ export function KbnTopNavControllerProvider($compile) {
     // apply the defaults to individual options
     _applyOptDefault(opt = {}) {
       const defaultedOpt = {
-        label: capitalize(opt.key),
+        label: opt.label ? opt.label : capitalize(opt.key),
         hasFunction: !!opt.run,
-        description: opt.run ? opt.key : `Toggle ${opt.key} view`,
+        description: opt.run ? opt.key : i18n.translate('common.ui.topNav.toggleViewAriaLabel', {
+          defaultMessage: 'Toggle {optKey} view',
+          values: { optKey: opt.key }
+        }),
         run: (item) => this.toggle(item.key),
         ...opt
       };

src/ui/public/management/sections_register.js

@@ -18,13 +18,18 @@
  */
 
 import { ManagementSection } from './section';
+import { i18n } from '@kbn/i18n';
 
 export const management = new ManagementSection('management', {
-  display: 'Management'
+  display: i18n.translate('common.ui.management.displayName', {
+    defaultMessage: 'Management'
+  })
 });
 
 management.register('data', {
-  display: 'Connect Data',
+  display: i18n.translate('common.ui.management.connectDataDisplayName', {
+    defaultMessage: 'Connect Data'
+  }),
   order: 0
 });
 

x-pack/plugins/graph/public/app.js

@@ -759,6 +759,9 @@ app.controller('graphuiPlugin', function ($scope, $route, $interval, $http, kbnU
   $scope.topNavMenu = [];
   $scope.topNavMenu.push({
     key: 'new',
+    label: i18n('xpack.graph.topNavMenu.newWorkspaceLabel', {
+      defaultMessage: 'New',
+    }),
     description: i18n('xpack.graph.topNavMenu.newWorkspaceAriaLabel', {
       defaultMessage: 'New Workspace',
     }),
@@ -770,6 +773,9 @@ app.controller('graphuiPlugin', function ($scope, $route, $interval, $http, kbnU
   if (!$scope.allSavingDisabled) {
     $scope.topNavMenu.push({
       key: 'save',
+      label: i18n('xpack.graph.topNavMenu.saveWorkspace.enabledLabel', {
+        defaultMessage: 'Save',
+      }),
       description: i18n('xpack.graph.topNavMenu.saveWorkspace.enabledAriaLabel', {
         defaultMessage: 'Save Workspace',
       }),
@@ -782,6 +788,9 @@ app.controller('graphuiPlugin', function ($scope, $route, $interval, $http, kbnU
   }else {
     $scope.topNavMenu.push({
       key: 'save',
+      label: i18n('xpack.graph.topNavMenu.saveWorkspace.disabledLabel', {
+        defaultMessage: 'Save',
+      }),
       description: i18n('xpack.graph.topNavMenu.saveWorkspace.disabledAriaLabel', {
         defaultMessage: 'Save Workspace',
       }),
@@ -793,6 +802,9 @@ app.controller('graphuiPlugin', function ($scope, $route, $interval, $http, kbnU
   }
   $scope.topNavMenu.push({
     key: 'open',
+    label: i18n('xpack.graph.topNavMenu.loadWorkspaceLabel', {
+      defaultMessage: 'Open',
+    }),
     description: i18n('xpack.graph.topNavMenu.loadWorkspaceAriaLabel', {
       defaultMessage: 'Load Saved Workspace',
     }),
@@ -807,6 +819,9 @@ app.controller('graphuiPlugin', function ($scope, $route, $interval, $http, kbnU
       disableButton: function () {
         return $route.current.locals === undefined || $route.current.locals.savedWorkspace === undefined;
       },
+      label: i18n('xpack.graph.topNavMenu.deleteWorkspace.enabledLabel', {
+        defaultMessage: 'Delete',
+      }),
       description: i18n('xpack.graph.topNavMenu.deleteWorkspace.enabledAriaLabel', {
         defaultMessage: 'Delete Saved Workspace',
       }),
@@ -845,6 +860,9 @@ app.controller('graphuiPlugin', function ($scope, $route, $interval, $http, kbnU
     $scope.topNavMenu.push({
       key: 'delete',
       disableButton: true,
+      label: i18n('xpack.graph.topNavMenu.deleteWorkspace.disabledLabel', {
+        defaultMessage: 'Delete',
+      }),
       description: i18n('xpack.graph.topNavMenu.deleteWorkspace.disabledAriaLabel', {
         defaultMessage: 'Delete Saved Workspace',
       }),
@@ -856,6 +874,9 @@ app.controller('graphuiPlugin', function ($scope, $route, $interval, $http, kbnU
   $scope.topNavMenu.push({
     key: 'settings',
     disableButton: function () { return $scope.selectedIndex === null; },
+    label: i18n('xpack.graph.topNavMenu.settingsLabel', {
+      defaultMessage: 'Settings',
+    }),
     description: i18n('xpack.graph.topNavMenu.settingsAriaLabel', {
       defaultMessage: 'Settings',
     }),

x-pack/plugins/spaces/public/lib/constants.ts

@@ -4,8 +4,14 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import { i18n } from '@kbn/i18n';
 import chrome from 'ui/chrome';
 
-export const SPACES_FEATURE_DESCRIPTION = `Organize your dashboards and other saved objects into meaningful categories.`;
+export const SPACES_FEATURE_DESCRIPTION = i18n.translate(
+  'xpack.spaces.featureRegistryDescription',
+  {
+    defaultMessage: 'Organize your dashboards and other saved objects into meaningful categories.',
+  }
+);
 
 export const MANAGE_SPACES_URL = chrome.addBasePath(`/app/kibana#/management/spaces/list`);

x-pack/plugins/spaces/public/register_feature.ts

@@ -4,6 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import { i18n } from '@kbn/i18n';
 import {
   FeatureCatalogueCategory,
   FeatureCatalogueRegistryProvider,
@@ -14,7 +15,9 @@ import { SPACES_FEATURE_DESCRIPTION } from './lib/constants';
 FeatureCatalogueRegistryProvider.register(() => {
   return {
     id: 'spaces',
-    title: 'Spaces',
+    title: i18n.translate('xpack.spaces.spacesTitle', {
+      defaultMessage: 'Spaces',
+    }),
     description: SPACES_FEATURE_DESCRIPTION,
     icon: 'spacesApp',
     path: '/app/kibana#/management/spaces/list',

x-pack/plugins/spaces/public/views/management/edit_space/manage_space_page.tsx

@@ -174,7 +174,14 @@ class ManageSpacePageUI extends Component<Props, State> {
           <Fragment>
             <EuiFlexGroup responsive={false}>
               <EuiFlexItem grow={false}>
-                <EuiFormRow label="Avatar">
+                <EuiFormRow
+                  label={
+                    <FormattedMessage
+                      id="xpack.spaces.management.manageSpacePage.avatarLabel"
+                      defaultMessage="Avatar"
+                    />
+                  }
+                >
                   <SpaceAvatar space={this.state.space} size="l" />
                 </EuiFormRow>
               </EuiFlexItem>