Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing apm-server response error monitor #26570

Merged
merged 6 commits into from
Dec 10, 2018
Merged

add missing apm-server response error monitor #26570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca93677
add missing apm-server response error monitor
graphaelli Dec 3, 2018
2ac038f
update test snapshot
graphaelli Dec 4, 2018
cef839a
update apm monitoring test fixture
graphaelli Dec 4, 2018
9278e1b
fix order
graphaelli Dec 4, 2018
e6db931
Fix failing spec
simitt Dec 6, 2018
c9c54ed
Merge branch 'master' into more-apm-monitoring
graphaelli Dec 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions x-pack/plugins/monitoring/server/lib/metrics/__test__/__snapshots__/metrics.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,47 @@ Object {
"units": "/m",
"uuidField": "cluster_uuid",
},
"apm_responses_errors_internal": ApmEventsRateClusterMetric {
"aggs": Object {
"beats_uuids": Object {
"aggs": Object {
"event_rate_per_beat": Object {
"max": Object {
"field": "beats_stats.metrics.apm-server.server.response.errors.internal",
},
},
},
"terms": Object {
"field": "beats_stats.beat.uuid",
"size": 10000,
},
},
"event_rate": Object {
"sum_bucket": Object {
"buckets_path": "beats_uuids>event_rate_per_beat",
"gap_policy": "skip",
},
},
"metric_deriv": Object {
"derivative": Object {
"buckets_path": "event_rate",
"gap_policy": "skip",
"unit": "1m",
},
},
},
"app": "apm",
"derivative": true,
"description": "HTTP Requests rejected due to a miscellaneous internal error",
"field": "beats_stats.metrics.apm-server.server.response.errors.internal",
"format": "0,0.[00]",
"label": "Internal",
"metricAgg": "max",
"timestampField": "beats_stats.timestamp",
"title": "Internal",
"units": "/m",
"uuidField": "cluster_uuid",
},
"apm_responses_errors_method": ApmEventsRateClusterMetric {
"aggs": Object {
"beats_uuids": Object {
Expand Down
12 changes: 12 additions & 0 deletions x-pack/plugins/monitoring/server/lib/metrics/apm/metrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,18 @@ export const metrics = {
defaultMessage: 'HTTP Requests rejected during server shutdown'
})
}),
apm_responses_errors_internal: new ApmEventsRateClusterMetric({
graphaelli marked this conversation as resolved.
Show resolved Hide resolved
field: 'beats_stats.metrics.apm-server.server.response.errors.internal',
title: i18n.translate('xpack.monitoring.metrics.apm.responseErrors.internalTitle', {
defaultMessage: 'Internal'
}),
label: i18n.translate('xpack.monitoring.metrics.apm.responseErrors.internalLabel', {
defaultMessage: 'Internal'
}),
description: i18n.translate('xpack.monitoring.metrics.apm.responseErrors.internalDescription', {
defaultMessage: 'HTTP Requests rejected due to a miscellaneous internal error'
})
}),

apm_processor_transaction_transformations: new ApmEventsRateClusterMetric({
field: 'beats_stats.metrics.apm-server.processor.transaction.transformations',
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/monitoring/server/routes/api/v1/apm/metric_set_instance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const metricSet = [
'apm_responses_errors_forbidden',
'apm_responses_errors_concurrency',
'apm_responses_errors_closed',
'apm_responses_errors_internal',
],
name: 'apm_responses_errors'
},
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/monitoring/server/routes/api/v1/apm/metric_set_overview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const metricSet = [
'apm_responses_errors_forbidden',
'apm_responses_errors_concurrency',
'apm_responses_errors_closed',
'apm_responses_errors_internal',
],
name: 'apm_responses_errors'
},
Expand Down
23 changes: 23 additions & 0 deletions x-pack/test/api_integration/apis/monitoring/apm/fixtures/cluster.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,29 @@
[1535723910000, 0],
[1535723940000, 0]
]
}, {
"bucket_size": "30 seconds",
"timeRange": {
"min": 1535720389104,
"max": 1535723989104
},
"metric": {
"app": "apm",
"field": "beats_stats.metrics.apm-server.server.response.errors.internal",
"metricAgg": "max",
"label": "Internal",
"title": "Internal",
"description": "HTTP Requests rejected due to a miscellaneous internal error",
"units": "/m",
"format": "0,0.[00]",
"hasCalculation": false,
"isDerivative": true
},
"data": [
[1535723880000, null],
[1535723910000, 0],
[1535723940000, 0]
]
}],
"apm_requests": [{
"bucket_size": "30 seconds",
Expand Down
23 changes: 23 additions & 0 deletions x-pack/test/api_integration/apis/monitoring/apm/fixtures/instance.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,29 @@
[1535723910000, 0],
[1535723940000, 0]
]
}, {
"bucket_size": "30 seconds",
"timeRange": {
"min": 1535720389104,
"max": 1535723989104
},
"metric": {
"app": "apm",
"field": "beats_stats.metrics.apm-server.server.response.errors.internal",
"metricAgg": "max",
"label": "Internal",
"title": "Internal",
"description": "HTTP Requests rejected due to a miscellaneous internal error",
"units": "/m",
"format": "0,0.[00]",
"hasCalculation": false,
"isDerivative": true
},
"data": [
[1535723880000, null],
[1535723910000, 0],
[1535723940000, 0]
]
}],
"apm_requests": [{
"bucket_size": "30 seconds",
Expand Down
5 changes: 4 additions & 1 deletion x-pack/test/functional/es_archives/monitoring/apm/mappings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@
},
"validate": {
"type": "long"
},
"internal": {
"type": "long"
}
}
},
Expand Down Expand Up @@ -685,4 +688,4 @@
},
"aliases": {}
}
}
}