Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BeatsCM] fix incorrect beat name in enroll command, remove translation of command #27036

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

mattapperson
Copy link
Contributor

This PR fixes the issue of the command only updated for beats enrollment if the OS type selector is changed.

To test, go to enroll a beat, change the OS selector, then change the beat type. If the beat type update in the command, then success 😊

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the bug on master and then on PR branch - LGTM!

@mattapperson mattapperson merged commit c039cd8 into elastic:master Dec 13, 2018
mattapperson added a commit to mattapperson/kibana that referenced this pull request Dec 14, 2018
mattapperson added a commit that referenced this pull request Dec 14, 2018
* [BeatsCM] Fix check for expiry_date_in_millis to allow for non-expiry (#27198)

* Fix check for expiry_date_in_millis to allow for non-expiry

* fix typo

* [BeatsCM] fix incorrect beat name in enroll command, remove translation of command (#27036)

* [Beats CM] Add basic license type (#26935)

* wrap non error in a try/catch (#26898)

* Log token errors to the server (#27170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants