Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Docs: Add sentence on where to change APM settings #27069

Merged
merged 1 commit into from
Dec 18, 2018
Merged

[APM] Docs: Add sentence on where to change APM settings #27069

merged 1 commit into from
Dec 18, 2018

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Dec 12, 2018 •
edited
Loading

Adding a sentence on where to change APM settings, per #24204

@bmorelli25 bmorelli25 added Team:Docs Team:APM All issues that need APM UI Team support labels Dec 12, 2018
@bmorelli25 bmorelli25 self-assigned this Dec 12, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

sorenlouv
sorenlouv approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmorelli25
Copy link
Member Author

@sqren - is it OK to merge even thought the build failed?

@sorenlouv
Copy link
Member

Generally no. Normally I would just re-run the build (you do that by comment "retest") but in this case it doesn't seem like a random failure. Rather it's due to invalid formatting in canvas:

21:21:29 /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/x-pack/plugins/canvas/canvas_plugin_src/uis/tags/index.js
21:21:29   2:1  error  Insert `·`  prettier/prettier
21:21:29   3:1  error  Insert `·`  prettier/prettier
21:21:29   4:1  error  Insert `·`  prettier/prettier
21:21:29   5:1  error  Insert `·`  prettier/prettier
21:21:29 
21:21:29 /var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/x-pack/plugins/canvas/public/components/workpad_loader/workpad_loader.js
21:21:29   374:31  error  Replace `⏎··············isLoading·&&·<div·style={{·width:·'100%'·}}>Fetching·Workpads...</div>` with `·isLoading·&&·(⏎··············<div·style={{·width:·'100%'·}}>Fetching·Workpads...</div>⏎············)`  prettier/prettier
21:21:29 
21:21:29 ✖ 5 problems (5 errors, 0 warnings)
21:21:29   5 errors and 0 warnings potentially fixable with the `--fix` option.

This might already be fixed, so try pulling in master.

@sorenlouv
Copy link
Member

It was fixed here: #26985.
So pulling in master should do the trick.

@bmorelli25
Copy link
Member Author

Hmmm...

@sorenlouv
Copy link
Member

🤞

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sorenlouv
Copy link
Member

retest

@sorenlouv
Copy link
Member

The latest failure looks to be intermittent. Let's try again. Third time's a charm...

@sorenlouv
Copy link
Member

@bmorelli25 I'm seeing the same error as you are. Seems to be a Kibana-wide issue right now - nothing we can do atm.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmorelli25
Copy link
Member Author

Makes sense - thanks for your help with this @sqren!

@bmorelli25
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmorelli25
Copy link
Member Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv
Copy link
Member

I'll be damned. A Christmas miracle 🥳🤶🎁

@bmorelli25
Copy link
Member Author

YES!!!!! 🥇🕺

@bmorelli25 bmorelli25 merged commit fcb0a6d into elastic:master Dec 18, 2018
@bmorelli25 bmorelli25 deleted the update-apm-settings branch December 18, 2018 23:05
graphaelli pushed a commit to graphaelli/kibana that referenced this pull request Mar 5, 2019
@bmorelli25 @graphaelli
docs: add sentence on where to change apm settings (elastic#27069)
17aa63b
@graphaelli graphaelli mentioned this pull request Mar 5, 2019
Merged
bmorelli25 added a commit to graphaelli/kibana that referenced this pull request Mar 12, 2019
@bmorelli25
docs: add sentence on where to change apm settings (elastic#27069)
3c0456a
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Mar 15, 2019
@bmorelli25
docs: add sentence on where to change apm settings (elastic#27069)
68d1ec1
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Mar 15, 2019
@bmorelli25
docs: add sentence on where to change apm settings (elastic#27069)
c6c87e6
This was referenced Mar 15, 2019
Merged
Merged
bmorelli25 added a commit that referenced this pull request Mar 15, 2019
@bmorelli25
Backport apm settings fixes 6.6 (#33343)
67e2180 
* fix spelling

# Conflicts:
#	docs/settings/apm-settings.asciidoc

* docs: add sentence on where to change apm settings (#27069)

* [DOCS] Removes X-Pack settings section (#30554)

Just the apm settings changes

* Updates &#42; characters to an escaped * (#22269)

GitHub's asciidoc parser handles `*` characters fine but markdown thinks its italicizing unless you escape the first asterisk. Subsequent asterisks on the same line can stay unescaped and should work fine.

# Conflicts:
#	docs/settings/apm-settings.asciidoc

* fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
Team:APM All issues that need APM UI Team support Team:Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmorelli25 @elasticmachine @sorenlouv @ogupte