Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move moment to peerDependency in elastic-datemath #27264

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 14, 2018

Summary

EUI is using elastic-datemath in the EuiSuperDatePicker component, elastic/eui#1351. There is a version conflict between elastic-datemath's moment dependency and EUI's moment dependency. Moving the moment dependency to a peer dependency should help alleviate some of these problems.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@spalger spalger added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 14, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@spalger spalger merged commit 4590991 into elastic:master Dec 14, 2018
spalger pushed a commit to spalger/kibana that referenced this pull request Dec 14, 2018
spalger pushed a commit that referenced this pull request Dec 15, 2018
)

Backports the following commits to 6.x:
 - move moment to peerDependency in elastic-datemath  (#27264)
@spalger
Copy link
Contributor

spalger commented Dec 15, 2018

6.x/6.6: c861627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants