Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Support for multiple Elasticsearch nodes and sniffing (#21928) #27431

Merged
merged 5 commits into from
Dec 19, 2018

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 18, 2018

  • Node sniffing

  • update monitoring

  • cleaning

  • remove tests

  • rewrite tests using the proxy

  • fix monitoring mocha tests

  • fix payload

  • return full error

  • default interval false

  • add sniff settings to monitoring

  • add docs for sniff settings

  • re-add index search integration test

  • catch parse error

  • capital

  • fix merge

  • hapi upgrade

  • return

  • pass by prefix

  • rm empty test fille

  • split error handling

  • fix merge

  • update recent elasticsearch.url references

  • prettier vs eslint

  • transport.request, include query params

  • mega comment

  • revert elasticsearchUrl

  • safe hosts

  • more docs es.url references

  • remove unused ml/esServerUrl

  • log if both set

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

* Node sniffing

* update monitoring

* cleaning

* remove tests

* rewrite tests using the proxy

* fix monitoring mocha tests

* fix payload

* return full error

* default interval false

* add sniff settings to monitoring

* add docs for sniff settings

* re-add index search integration test

* catch parse error

* capital

* fix merge

* hapi upgrade

* return

* pass by prefix

* rm empty test fille

* split error handling

* fix merge

* update recent elasticsearch.url references

* prettier vs eslint

* transport.request, include query params

* mega comment

* revert elasticsearchUrl

* safe hosts

* more docs es.url references

* remove unused ml/esServerUrl

* log if both set
@jbudz jbudz added the backport label Dec 18, 2018
@jbudz jbudz self-assigned this Dec 18, 2018
@jbudz jbudz changed the title Support for multiple Elasticsearch nodes and sniffing (#21928) [6.x] Support for multiple Elasticsearch nodes and sniffing (#21928) Dec 18, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jbudz
Copy link
Member Author

jbudz commented Dec 18, 2018

Jest Integration Tests.packages/kbn-plugin-helpers/tasks/build/integration_tests.creating the build skipInstallDependencies = false installs node_modules as a part of build (from packages_kbn-plugin-helpers_tasks_build_integration_tests_create_build.test.js) 
Error: ENOENT: no such file or directory, open '/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/immutable/kibana/packages/kbn-plugin-helpers/tasks/build/integration_tests/__fixtures__/create_build_test_plugin/build/kibana/create_build_test_plugin/translations/es.json

retest

@jbudz
Copy link
Member Author

jbudz commented Dec 18, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jbudz
Copy link
Member Author

jbudz commented Dec 18, 2018

 Error: expected '' to equal 'production'

@jbudz
Copy link
Member Author

jbudz commented Dec 18, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz jbudz merged commit 1275b79 into elastic:6.x Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants