Skip to content

Conversation

@alvarezmelissa87
Copy link
Contributor

Summary

Related issue: #21465

In datafeed_preview_tab.js:

  • add eui loading component when fetching datafeed previews
  • if no datafeed permissions, show permission warning callout

screen shot 2018-12-19 at 2 15 54 pm

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@alvarezmelissa87 alvarezmelissa87 added bug Fixes for quality problems that affect the customer experience review v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.6.0 v6.7.0 labels Dec 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml review v6.6.0 v6.7.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants