Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kuery/KQL: Support not passing an index pattern #28010

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

lukasolson
Copy link
Member

Fixes #28002.

This PR adds support for using Kuery/KQL without passing an index pattern object. When an index pattern is provided, we can use it to look at the fields list and more intelligently craft an Elasticsearch query, but if it's not provided we can still try our best to provide a query.

This also provides preliminary support for Kuery/KQL in Timelion/TSVB, but further support is added for TSVB in #26006.

@lukasolson lukasolson added review Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) v7.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:KQL KQL v6.6.0 labels Jan 3, 2019
@lukasolson lukasolson self-assigned this Jan 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 3, 2019

💔 Build Failed

java.lang.IllegalStateException: Channel is already closed

@markov00
Copy link
Member

markov00 commented Jan 3, 2019

retest

Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested the fix, and tested the new limited KQL support with TSVB on a dashboard. Pretty awesome for 87 lines changed. LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Test the fix and everything seems to work as expected

@markov00 markov00 merged commit 5de724f into elastic:master Jan 7, 2019
markov00 pushed a commit to markov00/kibana that referenced this pull request Jan 7, 2019
* Support not sending index pattern to Kuery functions

* fix match all inside is
markov00 pushed a commit to markov00/kibana that referenced this pull request Jan 7, 2019
* Support not sending index pattern to Kuery functions

* fix match all inside is
markov00 added a commit that referenced this pull request Jan 7, 2019
* Support not sending index pattern to Kuery functions

* fix match all inside is
markov00 added a commit that referenced this pull request Jan 7, 2019
* Support not sending index pattern to Kuery functions

* fix match all inside is
@markov00 markov00 mentioned this pull request Jan 8, 2019
1 task
@stacey-gammon stacey-gammon mentioned this pull request Jan 23, 2019
@lukasolson lukasolson deleted the kuerySupportNoIndexPattern branch December 2, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:KQL KQL Feature:Timelion Timelion app and visualization Feature:TSVB TSVB (Time Series Visual Builder) review Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants