-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuery/KQL: Support not passing an index pattern #28010
Kuery/KQL: Support not passing an index pattern #28010
Conversation
Pinging @elastic/kibana-app |
💔 Build Failed
|
retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, tested the fix, and tested the new limited KQL support with TSVB on a dashboard. Pretty awesome for 87 lines changed. LGTM!
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Test the fix and everything seems to work as expected
* Support not sending index pattern to Kuery functions * fix match all inside is
* Support not sending index pattern to Kuery functions * fix match all inside is
Fixes #28002.
This PR adds support for using Kuery/KQL without passing an index pattern object. When an index pattern is provided, we can use it to look at the fields list and more intelligently craft an Elasticsearch query, but if it's not provided we can still try our best to provide a query.
This also provides preliminary support for Kuery/KQL in Timelion/TSVB, but further support is added for TSVB in #26006.