Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Unused react-toggle dependency. #29086

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

varunsharma27
Copy link
Contributor

Removes Unused react-toggle dependency.

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@tsullivan
Copy link
Member

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@varunsharma27
Copy link
Contributor Author

Was that a flaky build?
The react-toggle stopped being used since this PR :-
https://github.com/elastic/kibana/pull/24250/files#diff-9d4d6ec060287056b0636184d20f8dfdL23

@tsullivan
Copy link
Member

@varunsharma27

It looks like the build failed because removing the dependency from package.json affects the yarn.lock file, and CI expects that you've run yarn kbn bootstrap to make the changes to yarn.lock locally and commit those in the branch.

Would you mind merging master once again (your baseline is probably too out of date for a pass to be valid), do the yarn kbn bootstrap, commit the changes to yarn.lock and push them?

@tsullivan
Copy link
Member

https://kibana-ci.elastic.co/job/elastic+kibana+pull-request/3474/JOB=kibana-intake,node=immutable/console

That link will expire in a few days, but here's what I saw when I looked at the first ci group console output:

11:58:28 Bootstrapping completed!
11:58:28 
11:58:28 Done in 266.43s.
11:58:28 
11:58:28 ERROR: 'yarn kbn bootstrap' caused changes to the following files:
11:58:28 
11:58:28 yarn.lock
11:58:28 
11:58:28 runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
11:58:28 runbld>>> DURATION: 366113ms
11:58:28 runbld>>> STDOUT: 11167 bytes
11:58:28 runbld>>> STDERR: 843 bytes
11:58:28 runbld>>> WRAPPED PROCESS: FAILURE (1)

@tsullivan
Copy link
Member

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsullivan tsullivan merged commit d301433 into elastic:master Mar 11, 2019
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Mar 11, 2019
* Removes Unused react-toggle dependency.

* PR elastic#29086 Updates yarn.lock
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Mar 11, 2019
* Removes Unused react-toggle dependency.

* PR elastic#29086 Updates yarn.lock
tsullivan added a commit that referenced this pull request Mar 13, 2019
* Removes Unused react-toggle dependency. (#29086)

* Removes Unused react-toggle dependency.

* PR #29086 Updates yarn.lock

* yarn changes
@rayafratkina rayafratkina added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 22, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants