Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes to text spacings in data visualizer cards #29438

Merged
merged 2 commits into from
Jan 29, 2019
Merged

[ML] Fixes to text spacings in data visualizer cards #29438

merged 2 commits into from
Jan 29, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jan 28, 2019 •
edited
Loading

Summary

Fixes a couple of minor styling issues on the Data Visualizer cards, with text spacing and the padding used in the title bar:

Before:
image

After:
image

Checklist

@peteharverson peteharverson added review non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 :ml Feature:Anomaly Detection ML anomaly detection v6.7.0 labels Jan 28, 2019
@peteharverson peteharverson requested a review from a team as a code owner January 28, 2019 16:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

walterra
walterra approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

alvarezmelissa87
alvarezmelissa87 approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

snide
snide reviewed Jan 29, 2019
View reviewed changes
x-pack/plugins/ml/public/components/field_title_bar/_field_title_bar.scss Outdated
@@ -1,9 +1,10 @@
.ml-field-title-bar {
color: $euiColorEmptyShade;
font-size: $euiFontSizeL;
line-height: $euiSizeL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but @include euiFontSizeL will give you size and line height together in a more stable format that's more vertical rhythm aware. It should even remove your need for the padding (didn't test).

https://github.com/elastic/eui/blob/master/src/global_styling/mixins/_typography.scss#L81-L84

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @snide. I've switched out the font-size and line-height for @include euiFontSizeL. Opted to retain just padding-bottom after testing.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 191fedf into elastic:master Jan 29, 2019
@peteharverson peteharverson deleted the ml-dataviz-style-fixes branch January 29, 2019 11:34
@peteharverson peteharverson mentioned this pull request Jan 29, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jan 29, 2019
@peteharverson
[ML] Fixes to text spacings in data visualizer cards (elastic#29438)
0062b48 
* [ML] Fixes to text spacings in data visualizer cards

* [ML] Switch to using euiFontSizeL include for field title bar
peteharverson added a commit that referenced this pull request Jan 29, 2019
@peteharverson
[ML] Fixes to text spacings in data visualizer cards (#29438) (#29499)
7c1a63c 
* [ML] Fixes to text spacings in data visualizer cards

* [ML] Switch to using euiFontSizeL include for field title bar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide left review comments

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes review v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peteharverson @elasticmachine @walterra @snide @alvarezmelissa87 @jgowdyelastic