[ML] Fixes caching/memoizing Anomaly Explorer data calls #29579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanged time ranges.
walterra
added
non-issue
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jan 31, 2019
…hanged time ranges. (elastic#29579) Fixes caching/memoizing Anomaly Explorer data calls related to changed time ranges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes caching/memoizing Anomaly Explorer data calls related to changed time ranges, an issue introduced in #28750. The PR introduced caching the data calls for anomaly explorer. The caching parameters didn't properly consider changed time ranges to invalidate the cache.
This fixes it by making the affected function calls more pure and moving the
timefilterdependency out of the functions and instead providingboundsas an argument which then can be used to check if the caching needs to be invalidated. By doing thistimefilterisn't necessary anymore as a dependency for the wholeexplorer_utils.jsfile.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately