Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] IE and Screen reader accesibility #29731

Merged
merged 7 commits into from
Feb 4, 2019
Merged

[CCR] IE and Screen reader accesibility #29731

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4edf05
Fix api endpoit for auto-follow stats
sebelga Jan 30, 2019
34a20c6
Prevent letter wrapping in IE for the Remote cluster "connection" tab…
sebelga Jan 31, 2019
35d3bae
Move inline style to CSS class to fix IE flex bug
sebelga Feb 1, 2019
9895bbf
Merge branch 'feature/ccr' into tests/ie-accessibility
sebelga Feb 1, 2019
a0f521b
Update jest snapshot
sebelga Feb 1, 2019
fc4b015
Merge remote-tracking branch 'upstream/feature/ccr' into tests/ie-acc…
sebelga Feb 4, 2019
2be46e0
Update failing test snapshot + update .remoteClustersConnectionStatu…
sebelga Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/cross_cluster_replication/public/app/services/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const updateFollowerIndex = (id, followerIndex) => (

/* Stats */
export const loadAutoFollowStats = () => (
httpClient.get(`${apiPrefix}/stats/auto-follow`).then(extractData)
httpClient.get(`${apiPrefix}/stats/auto_follow`).then(extractData)
);

/* Indices */
Expand Down
2 changes: 1 addition & 1 deletion ...ers/public/sections/remote_cluster_list/components/connection_status/connection_status.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function ConnectionStatus({ isConnected }) {
{icon}
</EuiFlexItem>

<EuiFlexItem>
<EuiFlexItem style={{ whiteSpace: 'nowrap' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not very well-documented, but it's a best practice for us to use classnames instead of inline styles. Could you create components/connection_status/_index.scss and create a class for this?

.remoteClustersConnectionStatus__message {
  white-space: nowrap;
}

You'll need to import this file from public/index.scss:

// At the top of the file
@import './sections/remote_cluster_list/components/connection_status/index'; // (note this can be index, not _index, because SCSS ignores the leading underscore in filenames)

Then we can apply the class like this:

<EuiFlexItem className="remoteClustersConnectionStatus__message">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

<EuiText>
{message}
</EuiText>
Expand Down