Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] IE and Screen reader accesibility #29731

Merged
merged 7 commits into from
Feb 4, 2019
Merged

[CCR] IE and Screen reader accesibility #29731

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4edf05
Fix api endpoit for auto-follow stats
sebelga Jan 30, 2019
34a20c6
Prevent letter wrapping in IE for the Remote cluster "connection" tab…
sebelga Jan 31, 2019
35d3bae
Move inline style to CSS class to fix IE flex bug
sebelga Feb 1, 2019
9895bbf
Merge branch 'feature/ccr' into tests/ie-accessibility
sebelga Feb 1, 2019
a0f521b
Update jest snapshot
sebelga Feb 1, 2019
fc4b015
Merge remote-tracking branch 'upstream/feature/ccr' into tests/ie-acc…
sebelga Feb 4, 2019
2be46e0
Update failing test snapshot + update .remoteClustersConnectionStatu…
sebelga Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/cross_cluster_replication/public/app/services/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const updateFollowerIndex = (id, followerIndex) => (

/* Stats */
export const loadAutoFollowStats = () => (
httpClient.get(`${apiPrefix}/stats/auto-follow`).then(extractData)
httpClient.get(`${apiPrefix}/stats/auto_follow`).then(extractData)
);

/* Indices */
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/remote_clusters/public/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Import the EUI global scope so we can use EUI constants
@import 'ui/public/styles/_styling_constants';
@import './sections/remote_cluster_list/components/connection_status/index';

// Index management plugin styles

Expand Down
3 changes: 3 additions & 0 deletions ...ote_clusters/public/sections/remote_cluster_list/components/connection_status/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.euiFlexGroup .euiFlexItem .remoteClustersConnectionStatus__message {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two classes make the selector somewhat brittlene, since it will no longer take effect if we refactor ConnectionStatus to use a component other than EuiFlexGroup or if the EUI classnames change. Can we change this to just the single class? It's OK to use !important if you need to override what's being inherited; a comment will help make the rationale clearer.

/**
 * 1. Prevent inherited flexbox layout from compressing this element on IE.
 */
.remoteClustersConnectionStatus__message {
  flex-basis: auto !important; / * 1 */
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I went with !important first and then remember that other sass linting projects I worked on did not allow them. You know, preferences 😄 Ok will change

flex-basis: auto;
}
2 changes: 1 addition & 1 deletion ...ers/public/sections/remote_cluster_list/components/connection_status/connection_status.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function ConnectionStatus({ isConnected }) {
{icon}
</EuiFlexItem>

<EuiFlexItem>
<EuiFlexItem className="remoteClustersConnectionStatus__message">
<EuiText>
{message}
</EuiText>
Expand Down
4 changes: 2 additions & 2 deletions .../remote_cluster_list/remote_cluster_table/__snapshots__/remote_cluster_table.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ exports[`RemoteClusterTable renders a row for an API-defined remote cluster 1`]
</svg>
</div>
<div
class="euiFlexItem"
class="euiFlexItem remoteClustersConnectionStatus__message"
>
<div
class="euiText euiText--medium"
Expand Down Expand Up @@ -336,7 +336,7 @@ exports[`RemoteClusterTable renders a row with a tooltip for a remote cluster de
</svg>
</div>
<div
class="euiFlexItem"
class="euiFlexItem remoteClustersConnectionStatus__message"
>
<div
class="euiText euiText--medium"
Expand Down