[ML] Fix double escaping. #30492
Merged
[ML] Fix double escaping. #30492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 8, 2019
Because the info tooltip has been migrated to React, the escaping necessary for the previous jQuery based tooltip resulting in a double escaping and special character visible in the tooltip. This fixes it by removing the now unnecessary escaping.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 8, 2019
Because the info tooltip has been migrated to React, the escaping necessary for the previous jQuery based tooltip resulting in a double escaping and special character visible in the tooltip. This fixes it by removing the now unnecessary escaping.
This was referenced Feb 8, 2019
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 8, 2019
Because the info tooltip has been migrated to React, the escaping necessary for the previous jQuery based tooltip resulting in a double escaping and special character visible in the tooltip. This fixes it by removing the now unnecessary escaping.
42 tasks
walterra
added a commit
that referenced
this pull request
Feb 8, 2019
lukeelmers
pushed a commit
to lukeelmers/kibana
that referenced
this pull request
Feb 8, 2019
Because the info tooltip has been migrated to React, the escaping necessary for the previous jQuery based tooltip resulting in a double escaping and special character visible in the tooltip. This fixes it by removing the now unnecessary escaping.
walterra
added a commit
that referenced
this pull request
Feb 14, 2019
walterra
added a commit
that referenced
this pull request
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30089. Because the info tooltip has been migrated to React, the escaping necessary for the previous jQuery based tooltip resulting in a double escaping and special character visible in the tooltip. This fixes it by removing the now unnecessary escaping.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately