Convert account screen to React/EUI #30977

legrego · 2019-02-13T17:29:41Z

Summary

This converts the account management screen to React/EUI.

Closes #30844

Account with no Full Name or email address

Account with Full Name and email address

Account with password change disabled (e.g., SAML):

i18n test:

TODO

"Release note: Refreshed the look-and-feel of the account management screen."

elasticmachine · 2019-02-13T17:29:43Z

Pinging @elastic/kibana-security

spalger · 2019-02-14T19:07:01Z

retest

elasticmachine · 2019-02-15T22:08:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

legrego · 2019-02-15T22:12:33Z

this is what I get for pushing updates without testing 😐

kobelb

nit: When changing your own password, if you enter an incorrect password the validation error is initially displayed correctly, but if you click "Change password" again, it clears the validation error:

kobelb · 2019-04-12T13:46:12Z

x-pack/plugins/security/public/lib/api.ts

+  }
+
+  public static async getUser(username: string): Promise<User> {
+    const url = `${usersUrl}/${username}`;


We weren't doing so previously, and the validation on the forms themselves is likely mitigating against this, but can we use encodeURIComponent here, and else-where in this file, when building URLs just to be safe?

You got it! a03183d

legrego · 2019-04-15T19:07:18Z

nit: When changing your own password, if you enter an incorrect password the validation error is initially displayed correctly, but if you click "Change password" again, it clears the validation error

Good catch, fixed in 08b0ac5. Thanks!

elasticmachine · 2019-04-15T20:04:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* WIP account management redesign * style updates * start implementing change password logic * restyle * remove api key management section * improved change password validation * first round of design edits * cleanup and testing * fix import * fix translations * fix error handling on user management page * consolidate password change logic * fix tests * happy linter, happy life * finish change password test * removes unused translations * fix typo in test * fix change password functional test * Design edits (#19) - Made `fullWidth` - Added a consistent password requirement help text - Use `title` for toast - Change username/email to us `dl` - Don’t use html elements in tests * clear password form on success * copy edits * fix handling of Change Password button * use encodeURIComponent for user supplied data

spalger · 2019-04-15T22:49:15Z

Reverted in a70a2cd

This reverts commit 031682d.

legrego · 2019-04-16T12:22:27Z

Resubmitted in #35151

## Summary This is a resubmission of #30977, which was reverted due to a functional test failure after merging. "Release note: Refreshed the look-and-feel of the account management screen."

## Summary This is a resubmission of elastic#30977, which was reverted due to a functional test failure after merging. "Release note: Refreshed the look-and-feel of the account management screen."

legrego added 8 commits February 12, 2019 07:44

WIP account management redesign

34989bc

style updates

5c58c97

start implementing change password logic

970421d

restyle

6fd7007

remove api key management section

1397cef

improved change password validation

bd5d965

first round of design edits

6002e73

cleanup and testing

8c3b297

legrego added WIP Work in progress Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Feb 13, 2019

legrego requested a review from a team as a code owner February 13, 2019 17:29