Fix IE11 by pinning top-level core-js node module to 2.5.3 #32159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
1 task
|
I ended up trying this by way of testing #31960. Fixed |
|
LGTM Let's get master unbroken in IE11 |
💚 Build Succeeded |
chandlerprall
added a commit
to chandlerprall/kibana
that referenced
this pull request
Mar 4, 2019
…2159) * Fix IE11 by pinning top-level core-js node module to 2.5.3 * Re-force core-js in yarn.lock
epixa
added
the
non-issue
chandlerprall
added a commit
that referenced
this pull request
Mar 4, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31693
The addition of storybook to canvas updated the version of
core-jsat the top-levelnode_modulesfrom 2.5.3 to 2.5.7 which, somehow, breaks IE11. This PR pinscore-jsto 2.5.3 and is much more of a patch than resolving the issue.Other things I tried, which had no effect:
core-jsversion - I updated yarn.lock so everything used 2.5.7 (except for one dependency which needs on v1), also tried latest2.6.4resolutionsto pincore-jsat 2.5.3It isn't that
core-jsisn't compatible with IE11, I can bring core-js's build into a new project and shim away. There is some underlying conflict without our dependencies that gets very, very unhappy if this setup changes.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately