Fix some strings after translator feedback #32501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Project:i18n
v7.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app |
timroes
commented
Mar 5, 2019
| @@ -71,7 +71,7 @@ class DashboardPanelUi extends React.Component<DashboardPanelUiProps, State> { | |||
| ? null | |||
| : props.intl.formatMessage({ | |||
| id: 'kbn.dashboard.panel.noEmbeddableFactoryErrorMessage', | |||
| defaultMessage: 'No factory found for embeddable', | |||
| defaultMessage: 'The feature to render this panel is missing.', | |||
There was a problem hiding this comment.
A bit less technical error message, and also under regular circumstances this should rarely ever been visible to a user.
wylieconlon
approved these changes
Mar 5, 2019
spalger
approved these changes
Mar 5, 2019
💔 Build Failed |
lukeelmers
approved these changes
Mar 5, 2019
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Mar 6, 2019
* Fix some strings after translator feedback * Fix jest tests * Fix typo * Fix Mocha tests * Fix more mocha tests
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Mar 6, 2019
* Fix some strings after translator feedback * Fix jest tests * Fix typo * Fix Mocha tests * Fix more mocha tests
timroes
added a commit
that referenced
this pull request
Mar 6, 2019
timroes
added a commit
that referenced
this pull request
Mar 6, 2019
PhilippBaranovskiy
pushed a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
* Fix some strings after translator feedback * Fix jest tests * Fix typo * Fix Mocha tests * Fix more mocha tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After some feedback we got from our translators, I added a couple of descriptions to some strings that seem troublesome. Also we discovered a couple of places that are not needed anymore at all (App descriptions, some weird Schema), where I removed the translations, and also a couple of places we used rather weird or technical wording I changed to a more appropriate wording (and removed the existing translations for the old string).
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately