Fix vislib legend entry width #33303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Feature:Vislib
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
cchaos
suggested changes
Mar 15, 2019
cchaos
approved these changes
Mar 15, 2019
💔 Build Failed |
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Mar 18, 2019
* Fix vislib legend entry width * Remove max-width
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Mar 18, 2019
* Fix vislib legend entry width * Remove max-width
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Mar 18, 2019
* Fix vislib legend entry width * Remove max-width
timroes
added a commit
that referenced
this pull request
Mar 25, 2019
timroes
added a commit
that referenced
this pull request
Mar 25, 2019
timroes
added a commit
that referenced
this pull request
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33193
I assume this broke in one of the SASS refactoring. This changes the width of each vislib legend entry to 100%, so you can hover over the whole legend and click it to toggle it. This is especially useful, for charts where the legend might only contain 1-2 letter labels and thus would be harder to hit.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately