-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bower & livereload #334
bower & livereload #334
Conversation
= relative urls changed relative urls to absolute urls = leaflet leaflet dont include their build in dist. that's why I used node_modules I had to change L.Icon.Default.imagePath because it was pointing to leaflet.label plugin = leftovers jquery vector map dont provide a build so it's still an unmanged dependecy bootstrap dark & light: custom css for kibana ?
I'm afraid I don't see the benefit to bower here. It forms a barrier to installation by creating an unnecessary dependency on nodejs. While this might have some small benefit to developers, it would annoy many users |
I totally agree with you. I will create a dist grunt task, every release this task will be run and package dependencies minified pushed into the repo |
== dist folder when developing dist folder contain source artifact when kibana is ready for a release the dist grunt task can be run to copy minified artifact in the dist folder if present. this way, we dont have to change the url/src inside of html and javascript files. One could have use grunt-usemin, but grunt-usemin would not parse javascript files thus, labjs could not point to the right artifact. It look like they use requirejs and have a way to set this up.... == bootstrap bootstrap/dark.css and bootstrap/light.css files are copied to bower_component to be generated. the output goes to dist since it's a product of the bootstrap artifact with bootstrap/dark the input text was gray on gray, so I added type=text in bootswatch to override that with white on gray. (arround line 423) == relative url switched some relative url to absolute url (load_big, js/*) == remove sample nodejs server connect is suitable for this
was not rendeing pie
@rashidkpc can you approve/disaprove this pull request so I can rebase it ? Thanks |
I'm going to close this, go ahead and rebase and I'll review it. |
Add encrypt message
* Changed dev dependency package.json. Used link to eslint-config-kibana instead of version number for @elastic/eslint-config-kibana * Added eslint-plugin-no-unsanitized
No description provided.