[Maps] add ability to load EMS resources with CORS #34503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
changed the title
thomasneirynck
force-pushed
the
maps/add_cors_ems
branch
from
10c8834
to
d1205fb
Compare
thomasneirynck
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💚 Build Succeeded |
thomasneirynck
requested review from
nreese,
kindsun and
alexfrancoeur
and removed request for
nreese
thomasneirynck
commented
Apr 5, 2019
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
nreese
reviewed
May 20, 2019
nreese
reviewed
May 20, 2019
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
|
Looks like relative URL are no longer supported. I am getting the following errors. This occurs when
|
💚 Build Succeeded |
nreese
approved these changes
May 21, 2019
|
lgtm! Tested locally with custom tile and region map services. My custom maps loaded directly with CORS while EMS services loaded via proxy when When Requests for custom region maps no longer include the |
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
May 21, 2019
- breaking change: by default, the Maps app now connects with CORS to EMS. This is optional - no longer include the kbn-version header when requesting files over CORS in region maps
|
Great feature! |
thomasneirynck
added a commit
that referenced
this pull request
May 22, 2019
This was referenced Jul 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34017
kibana.yml.Closes #36524
This also introduces an internal refactor.
This also fixes the bug that the initial-layer selection now correctly uses the tilemap.* config from kibana.yml when it is present
Discuss
This changes the default to use CORS (so the flag-config does not conflict with the default (and only behavior) in the region and coordinate map visualizations.We might want to backport this all the way to 6.7/7.0. For the backports, we would actually want to preserve the default of proxying EMS.It'd be something like:- 6.7.x: proxy EMS (as it is now)- 7.0.x: proxy EMS (as it is now)- 7.x: use CORS (breaking)- 8.0: use CORS (breaking)cc @alexfrancoeur