Passing correct pagination prop names for EuiInMemoryTable #34565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoristic
added
blocked
WIP
|
Pinging @elastic/stack-monitoring |
I think you meant:
:) |
💔 Build Failed |
💚 Build Succeeded |
|
@igoristic Is this ready for review yet? I saw me tagged but it's still in draft state |
💔 Build Failed |
|
It looks like the blocker here has been resolved in eui (elastic/eui#1794). Is this ready for review now? |
@chrisronline Getting pass the first blocker actually unveiled another blocker: elastic/eui#1909 I actually wanted to submit a pull request myself, but wasn't able to set up the EUI repo correctly. I will try to bring up the issue with the EUI team |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #32663
Corrected the pagination naming convention used in
EuiInMemoryTable.UPDATED:
Initial page index blocker has been implemented: elastic/eui#1794 which unveiled another blocker here: elastic/eui#1909